Re: [PATCH v2 09/26] cxl/test: Use device_set_node()

Jonathan Cameron
2025-05-08T11:47:45Z

On Wed, 7 May 2025 18:10:40 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Wed, May 07, 2025 at 09:12:51AM +0200, Herve Codina wrote:
> > The code set directly dev->fwnode.
> >
> > Use the dedicated helper to perform this operation.
>
> ...
>
> > @@ -1046,7 +1046,7 @@ static void mock_companion(struct acpi_device *adev, struct device *dev)
> > {
> > device_initialize(&adev->dev);
> > fwnode_init(&adev->fwnode, NULL);
> > - dev->fwnode = &adev->fwnode;
> > + device_set_node(dev, &adev->fwnode);
> > adev->fwnode.dev = dev;
> > }
>
> This code is questionable to begin with. Can the original author explain what
> is the motivation behind this as the only callers of fwnode_init() are deep
> core pieces _and_ this only module. Why?!
>

More likely to happen if CXL folk are +CC. Added.

Dan, maybe one for you?