Re: [PATCH v5 1/9] i2c: atr: Fix lockdep for nested ATRs

Wolfram Sang
2025-05-22T09:06:09Z

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

On Wed, May 07, 2025 at 03:19:07PM +0300, Cosmin Tanislav wrote:
> From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>
> When we have an ATR, and another ATR as a subdevice of the first ATR,
> we get lockdep warnings for the i2c_atr.lock and
> i2c_atr_chan.orig_addrs_lock. This is because lockdep uses a static key
> for the locks, and doesn't see the locks of the separate ATR instances
> as separate.
>
> Fix this by generating a dynamic lock key per lock instance.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

Your SoB is missing. I will add it for you if you confirm here.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]