From: Cosmin Tanislav <demonsingur@gmail.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Romain Gantois <romain.gantois@bootlin.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org,
Cosmin Tanislav <demonsingur@gmail.com>
Subject: [PATCH v5 5/9] i2c: atr: deduplicate logic in attach_addr()
Date: Wed, 7 May 2025 15:19:11 +0300 [thread overview]
Message-ID: <20250507121917.2364416-6-demonsingur@gmail.com> (raw)
In-Reply-To: <20250507121917.2364416-1-demonsingur@gmail.com>
This is the same logic as in i2c_atr_create_mapping_by_addr().
Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Reviewed-by: Romain Gantois <romain.gantois@bootlin.com>
---
drivers/i2c/i2c-atr.c | 30 ++++++------------------------
1 file changed, 6 insertions(+), 24 deletions(-)
diff --git a/drivers/i2c/i2c-atr.c b/drivers/i2c/i2c-atr.c
index 178b203c8777..ae5c2ee629f0 100644
--- a/drivers/i2c/i2c-atr.c
+++ b/drivers/i2c/i2c-atr.c
@@ -538,38 +538,20 @@ static int i2c_atr_attach_addr(struct i2c_adapter *adapter,
struct i2c_atr_chan *chan = adapter->algo_data;
struct i2c_atr *atr = chan->atr;
struct i2c_atr_alias_pair *c2a;
- u16 alias;
- int ret;
-
- ret = i2c_atr_reserve_alias(chan->alias_pool);
- if (ret < 0) {
- dev_err(atr->dev, "failed to find a free alias\n");
- return ret;
- }
-
- alias = ret;
+ int ret = 0;
mutex_lock(&chan->alias_pairs_lock);
- c2a = i2c_atr_create_c2a(chan, alias, addr);
+ c2a = i2c_atr_create_mapping_by_addr(chan, addr);
if (!c2a) {
- ret = -ENOMEM;
- goto err_release_alias;
+ dev_err(atr->dev, "failed to find a free alias\n");
+ ret = -EBUSY;
+ goto out_unlock;
}
- ret = atr->ops->attach_addr(atr, chan->chan_id, addr, alias);
- if (ret)
- goto err_del_c2a;
-
dev_dbg(atr->dev, "chan%u: using alias 0x%02x for addr 0x%02x\n",
- chan->chan_id, alias, addr);
+ chan->chan_id, c2a->alias, addr);
- goto out_unlock;
-
-err_del_c2a:
- i2c_atr_destroy_c2a(&c2a);
-err_release_alias:
- i2c_atr_release_alias(chan->alias_pool, alias);
out_unlock:
mutex_unlock(&chan->alias_pairs_lock);
return ret;
--
2.49.0
next prev parent reply other threads:[~2025-05-07 12:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 12:19 [PATCH v5 0/9] i2c: atr: allow usage of nested ATRs Cosmin Tanislav
2025-05-07 12:19 ` [PATCH v5 1/9] i2c: atr: Fix lockdep for " Cosmin Tanislav
2025-05-22 9:06 ` Wolfram Sang
2025-05-22 9:31 ` Cosmin Tanislav
2025-05-22 10:07 ` Luca Ceresoli
2025-05-22 10:08 ` Luca Ceresoli
2025-05-22 10:11 ` Wolfram Sang
2025-05-07 12:19 ` [PATCH v5 2/9] i2c: atr: find_mapping() -> get_mapping() Cosmin Tanislav
2025-05-07 12:19 ` [PATCH v5 3/9] i2c: atr: split up i2c_atr_get_mapping_by_addr() Cosmin Tanislav
2025-05-21 15:56 ` Luca Ceresoli
2025-05-07 12:19 ` [PATCH v5 4/9] i2c: atr: do not create mapping in detach_addr() Cosmin Tanislav
2025-05-07 12:19 ` Cosmin Tanislav [this message]
2025-05-07 12:19 ` [PATCH v5 6/9] i2c: atr: allow replacing mappings in attach_addr() Cosmin Tanislav
2025-05-21 15:56 ` Luca Ceresoli
2025-05-07 12:19 ` [PATCH v5 7/9] i2c: atr: add flags parameter to i2c_atr_new() Cosmin Tanislav
2025-05-22 8:50 ` Wolfram Sang
2025-05-22 10:10 ` Luca Ceresoli
2025-05-07 12:19 ` [PATCH v5 8/9] i2c: atr: add static flag Cosmin Tanislav
2025-05-21 15:56 ` Luca Ceresoli
2025-05-22 8:58 ` Wolfram Sang
2025-05-07 12:19 ` [PATCH v5 9/9] i2c: atr: add passthrough flag Cosmin Tanislav
2025-05-22 10:12 ` [PATCH v5 0/9] i2c: atr: allow usage of nested ATRs Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507121917.2364416-6-demonsingur@gmail.com \
--to=demonsingur@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=mchehab@kernel.org \
--cc=romain.gantois@bootlin.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox