From: Enrico Zanda <e.zanda1@gmail.com>
To: linux-i2c@vger.kernel.org
Cc: andi.shyti@kernel.org, Enrico Zanda <e.zanda1@gmail.com>
Subject: [PATCH 06/10] i2c: stm32: Replace dev_err() with dev_err_probe() in probe function
Date: Tue, 20 May 2025 21:43:56 +0200 [thread overview]
Message-ID: <20250520194400.341079-7-e.zanda1@gmail.com> (raw)
In-Reply-To: <20250520194400.341079-1-e.zanda1@gmail.com>
This simplifies the code while improving log.
Signed-off-by: Enrico Zanda <e.zanda1@gmail.com>
---
drivers/i2c/busses/i2c-stm32.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-stm32.c b/drivers/i2c/busses/i2c-stm32.c
index 157c64e27d0b..3ca84fef230c 100644
--- a/drivers/i2c/busses/i2c-stm32.c
+++ b/drivers/i2c/busses/i2c-stm32.c
@@ -39,7 +39,7 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
dma_sconfig.direction = DMA_MEM_TO_DEV;
ret = dmaengine_slave_config(dma->chan_tx, &dma_sconfig);
if (ret < 0) {
- dev_err(dev, "can't configure tx channel\n");
+ dev_err_probe(dev, ret, "can't configure tx channel\n");
goto fail_tx;
}
@@ -61,7 +61,7 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
dma_sconfig.direction = DMA_DEV_TO_MEM;
ret = dmaengine_slave_config(dma->chan_rx, &dma_sconfig);
if (ret < 0) {
- dev_err(dev, "can't configure rx channel\n");
+ dev_err_probe(dev, ret, "can't configure rx channel\n");
goto fail_rx;
}
--
2.43.0
next prev parent reply other threads:[~2025-05-20 19:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 19:43 [PATCH 00/10] i2c: Replace dev_err() with dev_err_probe() Enrico Zanda
2025-05-20 19:43 ` [PATCH 01/10] i2c: tiny-usb: Replace dev_err() with dev_err_probe() in probe function Enrico Zanda
2025-05-20 19:43 ` [PATCH 02/10] i2c: tegra: " Enrico Zanda
2025-05-20 19:43 ` [PATCH 03/10] i2c: sun6i-p2wi: " Enrico Zanda
2025-05-20 19:43 ` [PATCH 04/10] i2c: stm32f7: " Enrico Zanda
2025-05-20 19:43 ` [PATCH 05/10] i2c: stm32f4: " Enrico Zanda
2025-05-20 19:43 ` Enrico Zanda [this message]
2025-05-20 19:43 ` [PATCH 07/10] i2c: st: " Enrico Zanda
2025-05-20 19:43 ` [PATCH 08/10] i2c: sprd: " Enrico Zanda
2025-05-20 19:43 ` [PATCH 09/10] i2c: sis96x: " Enrico Zanda
2025-05-20 19:44 ` [PATCH 10/10] i2c: sis630: " Enrico Zanda
-- strict thread matches above, loose matches on Subject: below --
2026-03-24 18:26 [PATCH 00/10] i2c: Replace dev_err() with dev_err_probe() Atharv Dubey
2026-03-24 18:26 ` [PATCH 06/10] i2c: stm32: Replace dev_err() with dev_err_probe() in probe function Atharv Dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250520194400.341079-7-e.zanda1@gmail.com \
--to=e.zanda1@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox