Re: [PATCH v5 2/4] drm/xe: Support for I2C attached MCUs

Andi Shyti
2025-06-30T18:58:29Z

Hi,

On Fri, Jun 27, 2025 at 04:53:12PM +0300, Heikki Krogerus wrote:
> Adding adaption/glue layer where the I2C host adapter
> (Synopsys DesignWare I2C adapter) and the I2C clients (the
> microcontroller units) are enumerated.
>
> The microcontroller units (MCU) that are attached to the GPU
> depend on the OEM. The initially supported MCU will be the
> Add-In Management Controller (AMC).
>
> Originally-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

Looks very good.

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

(sorry for coming this late, but I've been on and off in this
period. I would have definitely loved to help on this)

Thanks,
Andi