Re: [PATCH v5 1/4] i2c: designware: Add quirk for Intel Xe

Heikki Krogerus
2025-07-01T07:45:42Z

On Mon, Jun 30, 2025 at 08:28:12PM +0200, Andi Shyti wrote:
> Hi Heikki,
>
> On Fri, Jun 27, 2025 at 04:53:11PM +0300, Heikki Krogerus wrote:
> > The regmap is coming from the parent also in case of Xe
> > GPUs. Reusing the Wangxun quirk for that.
>
> What I don't like, though, is that there is no mention of the
> change in the probe in the commit log.
>
> Besides, are these changes related? Can we have them split in two
> different patches? I guess this would also make Andy's point
> about the extra churn.

I think you are right about splitting the patch. I'll do just that.
Thanks for the review Andi.

--
heikki