Re: [PATCH v5 1/4] i2c: designware: Add quirk for Intel Xe

Rodrigo Vivi
2025-06-27T21:32:33Z

On Fri, Jun 27, 2025 at 05:13:36PM +0300, Andy Shevchenko wrote:
> On Fri, Jun 27, 2025 at 04:53:11PM +0300, Heikki Krogerus wrote:
> > The regmap is coming from the parent also in case of Xe
> > GPUs. Reusing the Wangxun quirk for that.
>
> ...
>
> > static int dw_i2c_plat_probe(struct platform_device *pdev)
> > {
> > + u32 flags = (uintptr_t)device_get_match_data(&pdev->dev);
>
> > - dev->flags = (uintptr_t)device_get_match_data(device);
> > if (device_property_present(device, "wx,i2c-snps-model"))
> > - dev->flags = MODEL_WANGXUN_SP | ACCESS_POLLING;
> > + flags = MODEL_WANGXUN_SP | ACCESS_POLLING;
> >
> > dev->dev = device;
> > dev->irq = irq;
> > + dev->flags = flags;
>
> Maybe I'm missing something, but why do we need these (above) changes?

in between, it is introduced a new one:
flags |= ACCESS_POLLING;

So, the initialization moved up, before the ACCESS_POLLING, and
it let the assignment to the last, along with the group.

Looks good to me:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

>
>
> --
> With Best Regards,
> Andy Shevchenko
>
>