Re: [PATCH v5 4/4] drm/xe/xe_i2c: Add support for i2c in survivability mode

Andi Shyti
2025-06-30T19:02:16Z

Hi Heikki and Riana,

> +err:
> + /*
> + * But if it fails, device can't enter survivability

nitpick: the "But" follows the "if". As we don't have the "if"
anymore, the "But" leaves the reader a bit flubbergasted :-)

If you are going to resend, please, remove it. Otherwise it can
be improved before submitting the patch.

In any case,

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Andi