Re: [PATCH v4 0/3] Fix STM32 I2C dma operations

Alain Volmat
2025-07-07T10:15:08Z

Hi Clément,

On Fri, Jul 04, 2025 at 10:39:13AM +0200, Clément Le Goffic wrote:
> This patch series aims to fix some issues inside the driver's DMA
> handling.
> It also uses newer I2C DMA API.
>
> Signed-off-by: Clément Le Goffic <clement.legoffic@foss.st.com>
> ---
> Changes in v4:
> - Patch[1]: Remove all `chan_dev` variable occurrencies
> - Patch[2]:
> - Refine commit message
> - Use the dma_callback to factorize the code
> - Patch[3]: Refine commit message
> - Link to v3: https://lore.kernel.org/r/20250630-i2c-upstream-v3-0-7a23ab26683a@foss.st.com
>
> Changes in v3:
> - Add Alain Volmat's "Acked-by" on patch 1 and 2
> - Link to v2: https://lore.kernel.org/r/20250627-i2c-upstream-v2-0-8c14523481dc@foss.st.com
>
> Changes in v2:
> - Fix the dev used in dma_unmap also in the error path of
> `stm32_i2c_prep_dma_xfer`
> - Add a dma_unmap_single also in the ITs error handler
> - Add Alain Volmat's "Acked-by" on patch 3
> - Link to v1: https://lore.kernel.org/r/20250616-i2c-upstream-v1-0-42d3d5374e65@foss.st.com
>
> ---
> Clément Le Goffic (3):
> i2c: stm32: fix the device used for the DMA map
> i2c: stm32f7: unmap DMA mapped buffer
> i2c: stm32f7: support i2c_*_dma_safe_msg_buf APIs
>
> drivers/i2c/busses/i2c-stm32.c | 8 +++---
> drivers/i2c/busses/i2c-stm32f7.c | 56 +++++++++++++++++++++-------------------
> 2 files changed, 33 insertions(+), 31 deletions(-)
> ---

Thanks for this new version of the serie.
This all looks good to me. My Acked-by are already set since v3 so
nothing more from me.

Regards,
Alain

> base-commit: d0b3b7b22dfa1f4b515fd3a295b3fd958f9e81af
> change-id: 20250527-i2c-upstream-e5b69501359a
>
> Best regards,
> --
> Clément Le Goffic <clement.legoffic@foss.st.com>
>