* [PATCH v2] i2c: Clarify behavior of I2C_M_RD flag
@ 2025-05-10 21:27 Viswanath
2025-05-19 16:45 ` Wolfram Sang
0 siblings, 1 reply; 7+ messages in thread
From: Viswanath @ 2025-05-10 21:27 UTC (permalink / raw)
To: linux-i2c; +Cc: Viswanath
Update the description of I2C_M_RD to clarify that not setting it
signals a write transaction
Signed-off-by: Viswanath <viswanathiyyappan@gmail.com>
---
include/uapi/linux/i2c.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/i2c.h b/include/uapi/linux/i2c.h
index aa751389de07..29b149ca4b70 100644
--- a/include/uapi/linux/i2c.h
+++ b/include/uapi/linux/i2c.h
@@ -21,7 +21,8 @@
*
* @flags:
* Supported by all adapters:
- * %I2C_M_RD: read data (from slave to master). Guaranteed to be 0x0001!
+ * %I2C_M_RD: read data (from slave to master). Guaranteed to be 0x0001! If
+ * not set, the transaction is interpreted as write.
*
* Optional:
* %I2C_M_DMA_SAFE: the buffer of this message is DMA safe. Makes sense only
--
2.49.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] i2c: Clarify behavior of I2C_M_RD flag
2025-05-10 21:27 [PATCH v2] i2c: Clarify behavior of I2C_M_RD flag Viswanath
@ 2025-05-19 16:45 ` Wolfram Sang
2025-07-09 15:00 ` I Viswanath
2025-07-09 15:07 ` [PATCH v2] " I Viswanath
0 siblings, 2 replies; 7+ messages in thread
From: Wolfram Sang @ 2025-05-19 16:45 UTC (permalink / raw)
To: Viswanath; +Cc: linux-i2c
[-- Attachment #1: Type: text/plain, Size: 332 bytes --]
On Sun, May 11, 2025 at 02:57:21AM +0530, Viswanath wrote:
> Update the description of I2C_M_RD to clarify that not setting it
> signals a write transaction
Well, ok, if one is new to I2C this might help understanding.
> Signed-off-by: Viswanath <viswanathiyyappan@gmail.com>
Can you please sign with your full name and resend?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* (no subject)
2025-05-19 16:45 ` Wolfram Sang
@ 2025-07-09 15:00 ` I Viswanath
2025-07-09 15:00 ` [PATCH v3] i2c: Clarify behavior of I2C_M_RD flag I Viswanath
2025-07-09 15:07 ` [PATCH v2] " I Viswanath
1 sibling, 1 reply; 7+ messages in thread
From: I Viswanath @ 2025-07-09 15:00 UTC (permalink / raw)
To: wsa+renesas; +Cc: linux-i2c, viswanathiyyappan
Hi Wolfram,
Updated the Signed-off-by line with my full legal name, as requested.
Thanks,
I Viswanath
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3] i2c: Clarify behavior of I2C_M_RD flag
2025-07-09 15:00 ` I Viswanath
@ 2025-07-09 15:00 ` I Viswanath
0 siblings, 0 replies; 7+ messages in thread
From: I Viswanath @ 2025-07-09 15:00 UTC (permalink / raw)
To: wsa+renesas; +Cc: linux-i2c, viswanathiyyappan
Update the description of I2C_M_RD to clarify that not setting it
signals a write transaction
Signed-off-by: I Viswanath <viswanathiyyappan@gmail.com>
---
include/uapi/linux/i2c.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/i2c.h b/include/uapi/linux/i2c.h
index 92326ebde350..a2db2a56c8b0 100644
--- a/include/uapi/linux/i2c.h
+++ b/include/uapi/linux/i2c.h
@@ -21,7 +21,8 @@
*
* @flags:
* Supported by all adapters:
- * %I2C_M_RD: read data (from slave to master). Guaranteed to be 0x0001!
+ * %I2C_M_RD: read data (from slave to master). Guaranteed to be 0x0001! If
+ * not set, the transaction is interpreted as write.
*
* Optional:
* %I2C_M_DMA_SAFE: the buffer of this message is DMA safe. Makes only sense
--
2.49.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] i2c: Clarify behavior of I2C_M_RD flag
2025-05-19 16:45 ` Wolfram Sang
2025-07-09 15:00 ` I Viswanath
@ 2025-07-09 15:07 ` I Viswanath
2025-07-09 15:07 ` [PATCH v3] " I Viswanath
1 sibling, 1 reply; 7+ messages in thread
From: I Viswanath @ 2025-07-09 15:07 UTC (permalink / raw)
To: wsa+renesas; +Cc: linux-i2c, viswanathiyyappan
Apologies, resending my previous reply with a proper subject line.
Hi Wolfram,
Updated the Signed-off-by line with my full legal name, as requested.
Thanks,
I Viswanath
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3] i2c: Clarify behavior of I2C_M_RD flag
2025-07-09 15:07 ` [PATCH v2] " I Viswanath
@ 2025-07-09 15:07 ` I Viswanath
2025-07-14 7:17 ` Wolfram Sang
0 siblings, 1 reply; 7+ messages in thread
From: I Viswanath @ 2025-07-09 15:07 UTC (permalink / raw)
To: wsa+renesas; +Cc: linux-i2c, viswanathiyyappan
Update the description of I2C_M_RD to clarify that not setting it
signals a write transaction
Signed-off-by: I Viswanath <viswanathiyyappan@gmail.com>
---
include/uapi/linux/i2c.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/i2c.h b/include/uapi/linux/i2c.h
index 92326ebde350..a2db2a56c8b0 100644
--- a/include/uapi/linux/i2c.h
+++ b/include/uapi/linux/i2c.h
@@ -21,7 +21,8 @@
*
* @flags:
* Supported by all adapters:
- * %I2C_M_RD: read data (from slave to master). Guaranteed to be 0x0001!
+ * %I2C_M_RD: read data (from slave to master). Guaranteed to be 0x0001! If
+ * not set, the transaction is interpreted as write.
*
* Optional:
* %I2C_M_DMA_SAFE: the buffer of this message is DMA safe. Makes only sense
--
2.49.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-07-14 7:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-10 21:27 [PATCH v2] i2c: Clarify behavior of I2C_M_RD flag Viswanath
2025-05-19 16:45 ` Wolfram Sang
2025-07-09 15:00 ` I Viswanath
2025-07-09 15:00 ` [PATCH v3] i2c: Clarify behavior of I2C_M_RD flag I Viswanath
2025-07-09 15:07 ` [PATCH v2] " I Viswanath
2025-07-09 15:07 ` [PATCH v3] " I Viswanath
2025-07-14 7:17 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).