Re: [PATCH 1/3] usb: misc: Add Intel USBIO bridge driver

[kernel test robot <lkp@intel.com>]

Hi Hans,

kernel test robot noticed the following build warnings:

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on usb/usb-next usb/usb-linus brgl/gpio/for-next andi-shyti/i2c/i2c-host linus/master v6.16 next-20250808]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Hans-de-Goede/usb-misc-Add-Intel-USBIO-bridge-driver/20250809-182506
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link:    https://lore.kernel.org/r/20250809102326.6032-2-hansg%40kernel.org
patch subject: [PATCH 1/3] usb: misc: Add Intel USBIO bridge driver
config: loongarch-randconfig-r052-20250810 (https://download.01.org/0day-ci/archive/20250810/202508100706.TBcpUB9u-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508100706.TBcpUB9u-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/usb/misc/usbio.c:661:19-21: WARNING !A || A && B is equivalent to !A || B

vim +661 drivers/usb/misc/usbio.c

   647	
   648	static int usbio_match_device_ids(struct acpi_device *adev, void *data)
   649	{
   650		struct usbio_match_ids_walk_data *wd = data;
   651		unsigned int id = 0;
   652		char *uid;
   653	
   654		if (!acpi_match_device_ids(adev, wd->hids)) {
   655			uid = acpi_device_uid(adev);
   656			if (uid)
   657				for (int i = 0; i < strlen(uid); i++)
   658					if (!kstrtouint(&uid[i], 10, &id))
   659						break;
   660	
 > 661			if (!uid || (uid && wd->id == (u8)id)) {
   662				wd->adev = adev;
   663				return 1;
   664			}
   665		}
   666	
   667		return 0;
   668	}
   669	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki