Re: [PATCH v5 2/3] gpio: Add Intel USBIO GPIO driver

Greg Kroah-Hartman
2025-09-11T13:31:51Z

On Thu, Sep 11, 2025 at 09:27:19AM -0400, Bartosz Golaszewski wrote:
> On Thu, 11 Sep 2025 15:18:31 +0200, Hans de Goede <hansg@kernel.org> said:
> > From: Israel Cepeda <israel.a.cepeda.lopez@intel.com>
> >
> > Add a a driver for the GPIO auxbus child device of the Intel USBIO USB
> > IO-expander used by the MIPI cameras on various new (Meteor Lake and
> > later) Intel laptops.
> >
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > Co-developed-by: Hans de Goede <hansg@kernel.org>
> > Signed-off-by: Hans de Goede <hansg@kernel.org>
> > Signed-off-by: Israel Cepeda <israel.a.cepeda.lopez@intel.com>
> > ---
> > Changes in v5:
> > - Move GPIO_USBIO Kconfig option under 'menu "USB GPIO expanders"'
> >
> > Changes in v4:
> > - Drop include <linux/dev_printk.h>, unneeded auxiliary_set_drvdata()
> >
> > Changes in v3:
> > - Drop (offset >= gc->ngpio) check and make usbio_gpio_get_bank_and_pin()
> > return void
> > - Propagate usbio_gpio_set() ret val in usbio_gpio_direction_output()
> > - Use devm_gpiochip_add_data() and drop auxiliary_driver remove() callback
> >
> > Changes in v2:
> > - Add a config_mutex protect usbio_gpio_update_config() calls, which
> > read-modify-write banks[x].config, racing with each other
> > - Adjust usbio_gpio_get() to have an int return value and propagate the
> > usbio_control_msg() return value
> > - Use __le16, __le32 type + cpu_to_le16() and friends for on wire words
> > - Some small style fixes from Sakari's review
>
> If Greg wants to take it:
>
> Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> or I can take it once patch 1/3 is in an immutable branch.

I'll just take it, simpler that way, thanks!

greg k-h