Re: [PATCH v8 0/9] i2c: fix, rework and extend RTL9300 I2C driver

Andi Shyti
2025-10-01T23:27:24Z

Hi Jonas,

> v8: - dropped accepted patches 1-3
> - fixed minor issue in last patch to make second master work
> - rebased on top of shyti/i2c/i2c-host to make sure it applies
> cleanly
>
> v7: - included given Tested-By and Reviewed-By from Chris Packham and
> Markus Stockhausen accordingly
> - except for Chris' Tested-By on RTL9310 since he only tested
> on RTL9302C
> - fixed typo as mentioned by Markuf Elfring
>
> v6: - patch 'i2c: rtl9300: check if xfer length is valid'
> - renamed to 'ensure data length is within supported range'
> - added I2C quirk for zero length as suggested by Wolfram Sang
> - reordered patches to have backport-worthy fixes first and
> enhancements/others after
> - patches 'fix channel number bound check', 'check if xfer
> length is valid' and 'remove SMBus Quick operation support'
> were moved before all others
> - added CC: stable to first three patches
> - fixed commit message of 'dt-bindings: i2c: realtek,rtl9301-i2c:
> extend for RTL9310 support'
> - added a patch to use guard(mutex) instead of explicit lock/unlock
> as suggested by Markus Elfring
> - added Reviewed-by: Rob Herring ... to dt-bindings patches
> - added Tested-by: Sven Eckelmann ... to all patches (except the
> new patch in this version)
>
> v5: - added more patches to fix further issues/do further cleanup
> - remove SMBus Quick support (not supported by hardware)
> - move setting SCL frequency to config_io
> - only set read message format (RD_MODE) once on probing
> - add check to avoid len = 0 being allowed as length
> - adjusted cover letter
>
> v4: - fixed an incorrect check for number of channels which was already
> present in original code
>
> v3: - narrowed vendor property per variant to be required only
> for RTL9310
> - narrowed usable child-node i2c addresses per variant
> - no changes to driver patches
>
> v2: - Patch 1:
> - adjusted commit message
> - retained Tested-By and Reviewed-By from Chris Packham
> - Patch 2:
> - simplified check as suggested by Markus Stockhausen
> - fixed commit message
> - Patch 3 (all requested by Krzysztof):
> - use vendor property instead of generic
> - add front compatibles to make binding complete
> - fix commit message
> - reordered patches, dt-bindings patch now comes before its 'user'
> - properly add device-tree list and relevant maintainers to To/Cc
>
> ---
> Jonas Jelonek (9):
> i2c: rtl9300: use regmap fields and API for registers
> dt-bindings: i2c: realtek,rtl9301-i2c: fix wording and typos
> i2c: rtl9300: rename internal sda_pin to sda_num
> i2c: rtl9300: move setting SCL frequency to config_io
> i2c: rtl9300: do not set read mode on every transfer
> i2c: rtl9300: separate xfer configuration and execution
> i2c: rtl9300: use scoped guard instead of explicit lock/unlock
> dt-bindings: i2c: realtek,rtl9301-i2c: extend for RTL9310 support
> i2c: rtl9300: add support for RTL9310 I2C controller

Thanks for resending and sorry for lingering on these. Merged to
i2c/i2c-host.

Thanks,
Andi