From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Artem Shimko <a.shimko.dev@gmail.com>
Cc: p.zabel@pengutronix.de, andi.shyti@kernel.org,
andriy.shevchenko@linux.intel.com, jarkko.nikula@linux.intel.com,
jsd@semihalf.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: designware-platdrv: handle reset control deassert error
Date: Thu, 9 Oct 2025 11:30:22 +0200 [thread overview]
Message-ID: <20251009093022.GH2912318@black.igk.intel.com> (raw)
In-Reply-To: <20251009083703.2038187-1-a.shimko.dev@gmail.com>
Hi,
On Thu, Oct 09, 2025 at 11:37:03AM +0300, Artem Shimko wrote:
> Handle the error returned by reset_control_deassert() in the probe
> function to prevent continuing probe when reset deassertion fails.
>
> Previously, reset_control_deassert() was called without checking its
> return value, which could lead to probe continuing even when the
> device reset wasn't properly deasserted.
>
> The fix checks the return value and returns an error with dev_err_probe()
> if reset deassertion fails, providing better error handling and
> diagnostics.
>
> Signed-off-by: Artem Shimko <a.shimko.dev@gmail.com>
Looks good to me,
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2025-10-09 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 7:44 [PATCH] i2c: designware-platdrv: handle reset control deassert error Artem Shimko
2025-10-09 8:15 ` Philipp Zabel
2025-10-09 8:37 ` Artem Shimko
2025-10-09 9:30 ` Mika Westerberg [this message]
2025-10-09 9:39 ` Philipp Zabel
2025-10-24 8:07 ` Artem Shimko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251009093022.GH2912318@black.igk.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=a.shimko.dev@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox