From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4B562EBDFD for ; Sat, 18 Oct 2025 09:14:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760778847; cv=none; b=TJ/OAFPwZ3ZCejgDzs1Qrg5XzswUHRYlBSLrja0TJm/72sIgoFx2SL4sfuxULv96JCuRtNVtwhJdNioSX45fXpAQgmzTWUOPLStvxODXIUJri5L+lqSJdQd/YU2dXlx2rilV/VD31OgKluroiuSjZS12MAuHTUnICqU1swzGoUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760778847; c=relaxed/simple; bh=h8vI1OluXSSJBLDiMPvfyfHYRqMJdQ8aWra4Wn19dbI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HxLrGlLJrUn9QyerkBmr87S105+6TQ5XdDC5wgdWHiKhDK0Jdg9IB0FXEC7SLGNrilbyA8Zy4GHyslSwzN9xmlhCZ0I0bHt24p5pGwrZJSj7sbuYKmrPPEj85dXFdZwPCOeCHTCwHk9OzwgzH6WMn6yA+wA399irlBgSE1RlqGE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DjmuNPcb; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DjmuNPcb" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3f2cf786abeso2277137f8f.3 for ; Sat, 18 Oct 2025 02:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760778844; x=1761383644; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HOKCu0zkFmuT3TdzBpwieB/b/YLMRGqn8lOHXlUlsOM=; b=DjmuNPcbunkdFgS7KFhmX2Lx+WSR+oE0Wqe5ZhguvU1DHvXeItTe+i1lSuKzr4QL9I XXGiHbBaX4CphPqTEhPI8Jou755srennutK+9Qta+aMsn/dUPvMDE1PZCFeDUdgHXi5S kGqSEP/LjOUkQEhbxIChDLzaqmjIEjOZgRaNyNI+zBq5ryWNLQnwUsASPzExtKmTNydE 4b2UjHS85EFnFjv0Q7mJLBgWswvOnOEvnlFy8ZmhMvEgeYQ434RWD59mn3rAsw+WnO96 JqjMm4aMN9ej0jRlPuI/98aie4wQKfjvJUprW/Tk3+kefnKGYk8gZ9+yRSzxFl2Iyg98 6qGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760778844; x=1761383644; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HOKCu0zkFmuT3TdzBpwieB/b/YLMRGqn8lOHXlUlsOM=; b=k8wjNujixVYSadI5iwxjbXOigJs3TEVJaYqHxRWX0icAEArwz0iH2IXKDO/DbIEgpM +XAyT+hYREQhAw6oGaEInLIzGCfrrVrvBbdyEM/dDuIN6PTaL8k1LXm+VWVmZBeI3DDD 6uE0vcQoWEu6YUVjOxmOFFc4NoW3B3mcmgGZ/5kT2cEKExWIIkjrxk0XuPaMne5utVKm LrJ+nH0eq8cVe6twKhGlQNS4w1n47hsPpbvzX47zIOjVDA3vS8UWlQd0NSMY1ZyBbO0W gB7Fi1mi9O8uVOjz2sU1i+yNrLkoFc/PaUgkQdoEiNEetKGbdlS6TqbKlRUDdMubpepe rDgA== X-Gm-Message-State: AOJu0YyJcubQIi6wxM9VINvDLJyfO53n1bmsQ0l90uJgY6QLKkM8fOZT 53mvdr4tqh4E2MXIQ5R+fHuzsChi+kJyYPDhCjw4ZjID8XlGBQbc1DlnqGz+Dw9r X-Gm-Gg: ASbGncuDRXLGyBIGxNJ3Zq7JcwGKg/zGSOMZvcqtjCAk5NaUME2/vRUKsk0iRfh7igE 9QB7r4VCDrugyPX7niBXCsmYNAgeKot74BKBRsKjqSfe60jZVXZbVUE28kwr72pbBvNXMmFUnx9 QRkOOq5ez1AzgPmqWLZQAkXGuVaoIXJd2fIr5M5tbztCaPmN3Ps4YlxiefPhPKsT3DM7Zi0mIGM DSGgQEnRurG28K81bgaVSE96kExBAVUsUA5LHMLASkzvniNfCYCQi19OaMqTsRWSoHV6lbiMUwO aX0VdpqvZTMKv4l4NlM1+mBT1QA0CTBYTRQOrg4d5D3c7FVJwXQwq6m25xBGovb6KwZkTzh2GBD 1ZeBci7wJ3vU8sAEhSyKHrb2p8V+z13x7mt+o8iwoYNCwqEDPQRbWxW7NlPrePsBFZ34KlvDPDz 8/JYPUqu6JYAg= X-Google-Smtp-Source: AGHT+IEnUmucqP+clc1J7H8PyJUVBC91ey+7MbB47Yf97h5uYlKqoAo6/jmHTzo8phjYWgEIm4e9bg== X-Received: by 2002:a05:6000:2f86:b0:426:fb28:7964 with SMTP id ffacd0b85a97d-42704dac9ddmr4901776f8f.61.1760778843896; Sat, 18 Oct 2025 02:14:03 -0700 (PDT) Received: from shift.. ([86.124.201.90]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-471144d17cdsm121034215e9.18.2025.10.18.02.14.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Oct 2025 02:14:02 -0700 (PDT) From: Cezar Chiru To: andi.shyti@kernel.org, wsa+renesas@sang-engineering.com Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Cezar Chiru Subject: [PATCH v7 3/3] i2c: pcf8584: Move 'ret' variable inside for loop, break if ret < 0. Date: Sat, 18 Oct 2025 12:12:58 +0300 Message-ID: <20251018091258.5266-4-chiru.cezar.89@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251018091258.5266-1-chiru.cezar.89@gmail.com> References: <20251018091258.5266-1-chiru.cezar.89@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Require spaces around '=', '>' and '<'. Add space(s) around binary operators. Move 'ret' variable inside for loop. Then check if (ret < 0) break. This improves usage of ret variable. Enforce errors fixing based on checkpatch.pl output on file. Signed-off-by: Cezar Chiru --- drivers/i2c/algos/i2c-algo-pcf.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/algos/i2c-algo-pcf.c b/drivers/i2c/algos/i2c-algo-pcf.c index 41a81d37e880..40c4d622e8c5 100644 --- a/drivers/i2c/algos/i2c-algo-pcf.c +++ b/drivers/i2c/algos/i2c-algo-pcf.c @@ -183,7 +183,7 @@ static int pcf_sendbytes(struct i2c_adapter *i2c_adap, const char *buf, struct i2c_algo_pcf_data *adap = i2c_adap->algo_data; int wrcount, status, timeout; - for (wrcount=0; wrcountalgo_data; struct i2c_msg *pmsg; int i; - int ret=0, timeout, status; + int timeout, status; if (adap->xfer_begin) adap->xfer_begin(adap->data); @@ -284,9 +284,10 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap, goto out; } - for (i = 0;ret >= 0 && i < num; i++) { - pmsg = &msgs[i]; + for (i = 0; i < num; i++) { + int ret = 0; + pmsg = &msgs[i]; ret = pcf_doAddress(adap, pmsg); /* Send START */ @@ -321,6 +322,9 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap, ret = pcf_sendbytes(i2c_adap, pmsg->buf, pmsg->len, (i + 1 == num)); } + + if (ret < 0) + break; } out: -- 2.43.0