From: Krzysztof Kozlowski <krzk@kernel.org>
To: Encrow Thorne <jyc0019@gmail.com>
Cc: Troy Mitchell <troy.mitchell@linux.spacemit.com>,
Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@gentoo.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Troy Mitchell <troymitchell988@gmail.com>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: i2c: spacemit: add optional resets
Date: Thu, 20 Nov 2025 09:13:51 +0100 [thread overview]
Message-ID: <20251120-warping-logical-skunk-0674f8@kuoka> (raw)
In-Reply-To: <20251119-i2c-k1_reset-support-v1-1-0e9e82bf9b65@gmail.com>
On Wed, Nov 19, 2025 at 07:46:43PM +0800, Encrow Thorne wrote:
> Add optional reset property for the SpacemiT K1 I2C.
Why? You just repeated diff and we can read the diff. Please explain WHY
you are doing things in terms of hardware.
>
> Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
> ---
> Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml b/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> index b7220fff2235..3d4faec41abe 100644
> --- a/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> @@ -27,6 +27,9 @@ properties:
> - description: I2C Functional Clock
> - description: APB Bus Clock
>
> + resets:
> + maxItems: 1
> +
Completely misplaced. There are never random properties between xxx and
xxx-names.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-20 8:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 11:46 [PATCH 0/3] i2c: spacemit: add reset support Encrow Thorne
2025-11-19 11:46 ` [PATCH 1/3] dt-bindings: i2c: spacemit: add optional resets Encrow Thorne
2025-11-19 12:11 ` Troy Mitchell
2025-11-20 8:13 ` Krzysztof Kozlowski [this message]
2025-11-19 11:46 ` [PATCH 2/3] i2c: k1: add reset support Encrow Thorne
2025-11-19 12:08 ` Troy Mitchell
2025-12-11 7:35 ` Guodong Xu
2025-12-16 5:21 ` Encrow Thorne
2025-11-19 11:46 ` [PATCH 3/3] riscv: dts: spacemit: add reset property Encrow Thorne
2025-11-19 12:10 ` Troy Mitchell
-- strict thread matches above, loose matches on Subject: below --
2025-12-30 14:29 [PATCH v3 0/3] i2c: spacemit: add reset support Encrow Thorne
2025-12-30 15:06 ` [PATCH 1/3] dt-bindings: i2c: spacemit: add optional resets Encrow Thorne
2026-01-05 18:44 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251120-warping-logical-skunk-0674f8@kuoka \
--to=krzk@kernel.org \
--cc=alex@ghiti.fr \
--cc=andi.shyti@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=jyc0019@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=troy.mitchell@linux.spacemit.com \
--cc=troymitchell988@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox