Re: [PATCH] i2c: i2c-elektor: Allow building on SMP kernels

John Paul Adrian Glaubitz
2025-11-24T22:42:05Z

On Mon, 2025-11-24 at 20:49 +0000, Maciej W. Rozycki wrote:
> On Sat, 22 Nov 2025, John Paul Adrian Glaubitz wrote:
>
> > > there has since been some fixes/cleanup work to get rid of cli/sti and
> >
> > s/has/have/
>
> An ambiguity here comes from the mixture of plural and uncountable for
> "fixes" vs "... work".
>
> > > rely on spinlocks instead (as pointed out by Wolfram Sang). Tested this
> >
> > The sentence just ends after "instead". I think you meant to say "instead,
> > let's allow building the driver on SMP kernels again." or something like
> > that.
>
> FWIW I can see nothing wrong with the sentence, "... get rid of cli/sti
> and rely on spinlocks instead." seems like standard English usage to me.

Yes, I was probably misreading it. Either way, I think the v2 looks fine.

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913