Re: [PATCH v2 18/19] dt-bindings: arm: microchip: document EV23X71A board

Robert Marko
2025-12-23T15:29:35Z

On Tue, Dec 23, 2025 at 3:43 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Tue, Dec 23, 2025 at 11:34:55AM +0100, Robert Marko wrote:
> > On Tue, Dec 16, 2025 at 6:32 PM Conor Dooley <conor@kernel.org> wrote:
> > >
> > > On Mon, Dec 15, 2025 at 05:35:35PM +0100, Robert Marko wrote:
> > > > Microchip EV23X71A board is an LAN9696 based evaluation board.
> > > >
> > > > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > > > ---
> > > > Documentation/devicetree/bindings/arm/microchip.yaml | 8 ++++++++
> > > > 1 file changed, 8 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/arm/microchip.yaml b/Documentation/devicetree/bindings/arm/microchip.yaml
> > > > index 910ecc11d5d7..b20441edaac7 100644
> > > > --- a/Documentation/devicetree/bindings/arm/microchip.yaml
> > > > +++ b/Documentation/devicetree/bindings/arm/microchip.yaml
> > > > @@ -239,6 +239,14 @@ properties:
> > > > - const: microchip,lan9668
> > > > - const: microchip,lan966
> > > >
> > > > + - description: The LAN969x EVB (EV23X71A) is a 24x 1G + 4x 10G
> > > > + Ethernet development system board.
> > > > + - items:
> > > > + - enum:
> > > > + - microchip,ev23x71a
> > > > + - microchip,lan9696
> > >
> > > This looks wrong, unless "microchip,lan9696" is a board (which I suspect
> > > it isn't).
> >
> > Hi,
> > No, LAN9696 is the exact SoC SKU used on the board.
> > I will drop it in v3.
>
> Instead of dropping it, this should become an items list with 3 consts I
> think.

Ok, that lines up with what other boards in the binding do, will do that in v3.

Regards,
Robert

--
Robert Marko
Staff Embedded Linux Engineer
Sartura d.d.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr