Re: [PATCH v2 16/19] dt-bindings: pinctrl: pinctrl-microchip-sgpio: add LAN969x

Conor Dooley
2025-12-16T17:33:59Z

[-- Attachment #1: Type: text/plain, Size: 1755 bytes --]

On Mon, Dec 15, 2025 at 05:35:33PM +0100, Robert Marko wrote:
> Document LAN969x compatibles for SGPIO.
>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
> .../pinctrl/microchip,sparx5-sgpio.yaml | 20 ++++++++++++++-----
> 1 file changed, 15 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml b/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml
> index fa47732d7cef..9fbbafcdc063 100644
> --- a/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml
> @@ -21,10 +21,15 @@ properties:
> pattern: '^gpio@[0-9a-f]+$'
>
> compatible:
> - enum:
> - - microchip,sparx5-sgpio
> - - mscc,ocelot-sgpio
> - - mscc,luton-sgpio
> + oneOf:
> + - enum:
> + - microchip,sparx5-sgpio
> + - mscc,ocelot-sgpio
> + - mscc,luton-sgpio
> + - items:
> + - enum:
> + - microchip,lan9691-sgpio
> + - const: microchip,sparx5-sgpio
>
> '#address-cells':
> const: 1
> @@ -80,7 +85,12 @@ patternProperties:
> type: object
> properties:
> compatible:
> - const: microchip,sparx5-sgpio-bank

This should just be able to become "compatible: contains: const: microchip,sparx5-sgpio-bank.
pw-bot: changes-requested

> + oneOf:
> + - items:
> + - enum:
> + - microchip,lan9691-sgpio-bank
> + - const: microchip,sparx5-sgpio-bank
> + - const: microchip,sparx5-sgpio-bank
>
> reg:
> description: |
> --
> 2.52.0
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]