Re: [PATCH v2 1/3] dt-bindings: i2c: spacemit: add optional resets

Troy Mitchell
2025-12-26T03:27:26Z

On Fri, Dec 19, 2025 at 09:03:14AM +0100, Krzysztof Kozlowski wrote:
> On 19/12/2025 08:42, Encrow Thorne wrote:
> > The I2C controller requires a reset to ensure it starts from a clean state.
> >
> > Add the 'resets' property to support this hardware requirement.
> >
> > Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
> > ---
> > Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml b/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> > index b7220fff2235..1290106e28e6 100644
> > --- a/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> > @@ -32,6 +32,9 @@ properties:
> > - const: func
> > - const: bus
> >
> > + resets:
> > + maxItems: 1
> > +
>
> Still between other clock-related properties. You already got such
> comment...
Please replace it below clock-frequency.
With this fix, you can add my tag:

Reviewed-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
>
> > clock-frequency:
> > description: |
> > K1 support three different modes which running different frequencies
> >
>
>
> Best regards,
> Krzysztof
>