Re: [PATCH v2 2/3] i2c: k1: add reset support

Andi Shyti
2025-12-27T19:26:28Z

Hi Guodong,

On Fri, Dec 26, 2025 at 07:38:22AM +0800, Guodong Xu wrote:
> On Fri, Dec 26, 2025 at 5:01 AM Andi Shyti <andi.shyti@kernel.org> wrote:
> > > + rst = devm_reset_control_get_optional_exclusive_deasserted(dev, NULL);
> > > + if (IS_ERR(rst))
> > > + return dev_err_probe(dev, PTR_ERR(rst),
> > > + "failed to acquire deasserted reset\n");
> >
> > If this is optional, why are we returning with error?
> >
>
> According to include/linux/reset.h, if the requested reset is not
> specified in the device tree, this function returns NULL instead of
> an error. Therefore, IS_ERR(rst) will only be true for actual
> errors (e.g probe deferral).

And this is quite obvious, but you haven't answered my qestion.

Why do we care of internal failures in reset? If reset fails on
an optional reset control function why should we kill our driver?
Just ignore the error and move forward as we have done until now.

If the kernel is suffering from internal failures (say ENOMEM),
it will fail anyway or, with some luck, recover.

Andi