From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: correctmost <cmlists@sent.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
dmaengine@vger.kernel.org, regressions@lists.linux.dev,
vkoul@kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [REGRESSION][BISECTED] Lenovo IdeaPad touchpad does not work when idma64 is present in initramfs
Date: Thu, 29 Jan 2026 12:56:09 +0100 [thread overview]
Message-ID: <20260129115609.GV2275908@black.igk.intel.com> (raw)
In-Reply-To: <513c490f-c433-4298-ae66-6e165aa7b299@app.fastmail.com>
On Thu, Jan 29, 2026 at 02:20:22AM -0500, correctmost wrote:
> >> > Can you next apply the below patch (only that one) and try? Any test case
> >> > where it reproduces is good. The provide again full dmesg. While at it can
> >> > you enable CONFIG_PRINTK_TIME=y so we can also get timestamps to the dmesg.
> >>
> >> Full log attached with the added debug prints and timestamps
> >
> > Thanks! Okay so the interrupt is active immediately when the LPSS probes.
> > One thing that could explain this is that the IO-APIC is misconfigured to
> > have the polarity reversed. Can you boot with "apic=debug" in the kernel
> > command line so that it dumps the entries and provide again full dmesg?
>
> Sure, full log attached
Thanks! The IO-APIC configuration seems fine too. I also compared with my
MTLP based reference system and it shows the same (but my system does not
have this issue).
Let's add even more debug. Can you replace the previous hack patch with the
below.
You can drop the "apic=debug" from the command line but can you add
acpi.dyndbg=+p" instead.
Then also enable CONFIG_PCI_DEBUG=y.
diff --git a/drivers/dma/idma64.c b/drivers/dma/idma64.c
index d147353d47ab..9c06b137ed0b 100644
--- a/drivers/dma/idma64.c
+++ b/drivers/dma/idma64.c
@@ -6,6 +6,7 @@
* Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
*/
+#define DEBUG
#include <linux/bitops.h>
#include <linux/delay.h>
#include <linux/dmaengine.h>
@@ -171,6 +172,8 @@ static irqreturn_t idma64_irq(int irq, void *dev)
u32 status_err;
unsigned short i;
+ dev_dbg_ratelimited(idma64->dma.dev, "status=%#x\n", status);
+
/* Since IRQ may be shared, check if DMA controller is powered on */
if (status == GENMASK(31, 0))
return IRQ_NONE;
diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c
index 5b1e8f74c4ac..6be3ce3edd4b 100644
--- a/drivers/i2c/busses/i2c-designware-common.c
+++ b/drivers/i2c/busses/i2c-designware-common.c
@@ -772,12 +772,17 @@ static int i2c_dw_runtime_suspend(struct device *device)
{
struct dw_i2c_dev *dev = dev_get_drvdata(device);
+ dev_info(device, "runtime suspend start\n");
+
+
if (dev->shared_with_punit)
return 0;
i2c_dw_disable(dev);
i2c_dw_prepare_clk(dev, false);
+ dev_info(device, "runtime suspend finished\n");
+
return 0;
}
@@ -794,11 +799,15 @@ static int i2c_dw_runtime_resume(struct device *device)
{
struct dw_i2c_dev *dev = dev_get_drvdata(device);
+ dev_info(device, "runtime resume start\n");
+
if (!dev->shared_with_punit)
i2c_dw_prepare_clk(dev, true);
dev->init(dev);
+ dev_info(device, "runtime resume finished\n");
+
return 0;
}
diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
index 45bfca05bb30..7461254ec863 100644
--- a/drivers/i2c/busses/i2c-designware-master.c
+++ b/drivers/i2c/busses/i2c-designware-master.c
@@ -10,6 +10,7 @@
*/
#define DEFAULT_SYMBOL_NAMESPACE "I2C_DW"
+#define DEBUG
#include <linux/delay.h>
#include <linux/err.h>
@@ -756,6 +757,7 @@ static irqreturn_t i2c_dw_isr(int this_irq, void *dev_id)
regmap_read(dev->map, DW_IC_ENABLE, &enabled);
regmap_read(dev->map, DW_IC_RAW_INTR_STAT, &stat);
+ dev_dbg_ratelimited(dev->dev, "enabled=%#x stat=%#x\n", enabled, stat);
if (!enabled || !(stat & ~DW_IC_INTR_ACTIVITY))
return IRQ_NONE;
if (pm_runtime_suspended(dev->dev) || stat == GENMASK(31, 0))
diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index 63d6694f7145..b82a22e5977f 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -501,6 +501,8 @@ static int intel_lpss_suspend(struct device *dev)
struct intel_lpss *lpss = dev_get_drvdata(dev);
unsigned int i;
+ dev_info(dev, "supend started\n");
+
/* Save device context */
for (i = 0; i < LPSS_PRIV_REG_COUNT; i++)
lpss->priv_ctx[i] = readl(lpss->priv + i * 4);
@@ -513,6 +515,8 @@ static int intel_lpss_suspend(struct device *dev)
if (lpss->type != LPSS_DEV_UART)
writel(0, lpss->priv + LPSS_PRIV_RESETS);
+ dev_info(dev, "supend finished\n");
+
return 0;
}
@@ -521,12 +525,16 @@ static int intel_lpss_resume(struct device *dev)
struct intel_lpss *lpss = dev_get_drvdata(dev);
unsigned int i;
+ dev_info(dev, "resume started\n");
+
intel_lpss_deassert_reset(lpss);
/* Restore device context */
for (i = 0; i < LPSS_PRIV_REG_COUNT; i++)
writel(lpss->priv_ctx[i], lpss->priv + i * 4);
+ dev_info(dev, "resume finished\n");
+
return 0;
}
next prev parent reply other threads:[~2026-01-29 11:56 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 17:57 [REGRESSION][BISECTED] Lenovo IdeaPad touchpad does not work when idma64 is present in initramfs correctmost
2026-01-12 14:35 ` Andy Shevchenko
2026-01-12 16:52 ` Andy Shevchenko
2026-01-15 22:50 ` correctmost
2026-01-16 10:03 ` Andy Shevchenko
2026-01-16 10:35 ` Andy Shevchenko
2026-01-17 0:25 ` correctmost
2026-01-19 10:39 ` Andy Shevchenko
2026-01-19 10:49 ` Andy Shevchenko
2026-01-20 9:33 ` Andy Shevchenko
2026-01-21 4:56 ` correctmost
2026-01-21 9:13 ` Andy Shevchenko
2026-01-21 13:58 ` Mika Westerberg
2026-01-21 14:54 ` Andy Shevchenko
2026-01-21 15:02 ` Mika Westerberg
2026-01-21 15:19 ` Andy Shevchenko
2026-01-22 11:00 ` Mika Westerberg
2026-01-22 22:29 ` correctmost
2026-01-23 6:36 ` Mika Westerberg
2026-01-25 3:38 ` correctmost
2026-01-26 13:53 ` Mika Westerberg
2026-01-27 6:52 ` correctmost
2026-01-27 8:42 ` Mika Westerberg
2026-01-27 10:11 ` correctmost
2026-01-27 10:19 ` Mika Westerberg
2026-01-27 10:56 ` correctmost
2026-01-27 14:43 ` Mika Westerberg
2026-01-27 15:09 ` Andy Shevchenko
2026-01-28 3:06 ` correctmost
2026-01-23 6:53 ` Andy Shevchenko
2026-01-28 9:34 ` Andy Shevchenko
2026-01-28 10:21 ` correctmost
2026-01-28 12:31 ` Mika Westerberg
2026-01-29 4:54 ` correctmost
2026-01-29 6:58 ` Mika Westerberg
2026-01-29 7:20 ` correctmost
2026-01-29 11:56 ` Mika Westerberg [this message]
2026-01-29 13:06 ` correctmost
2026-01-30 7:26 ` Mika Westerberg
2026-01-30 8:18 ` correctmost
2026-02-02 7:51 ` Mika Westerberg
2026-02-02 8:38 ` correctmost
2026-02-02 10:22 ` Mika Westerberg
2026-02-02 11:16 ` correctmost
2026-02-03 10:04 ` Mika Westerberg
2026-02-03 12:39 ` correctmost
2026-02-04 12:31 ` Mika Westerberg
2026-02-04 13:11 ` correctmost
2026-02-04 13:19 ` Andy Shevchenko
2026-02-04 14:01 ` correctmost
2026-02-04 15:12 ` correctmost
2026-02-04 15:34 ` Mika Westerberg
2026-02-04 15:53 ` correctmost
2026-02-05 10:31 ` Mika Westerberg
2026-02-14 20:17 ` correctmost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260129115609.GV2275908@black.igk.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cmlists@sent.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=regressions@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox