From: Artem Shimko <a.shimko.dev@gmail.com>
To: andi.shyti@kernel.org, p.zabel@pengutronix.de,
mika.westerberg@linux.intel.com,
andriy.shevchenko@linux.intel.com, jsd@semihalf.com
Cc: Artem Shimko <a.shimko.dev@gmail.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v6 0/2] i2c: designware-platdrv: simplify reset control and fix cleanup on probe failure
Date: Fri, 30 Jan 2026 14:10:35 +0300 [thread overview]
Message-ID: <20260130111039.874548-1-a.shimko.dev@gmail.com> (raw)
This series simplifies error handling and reset control management in
the DesignWare I2C platform driver.
Patch 1 replaces the manual reset control acquisition and deassertion
with the devm_reset_control_get_optional_exclusive_deasserted()
function. This simplifies the code by eliminating explicit deassertion
calls and associated error handling while maintaining the same
functionality through automatic resource management.
Patch 2 removes the unnecessary goto label for cleanup on probe failure.
The cleanup operations are straightforward and can be handled directly
in the error path, making the control flow more readable without
changing the error handling semantics.
Thank you!
--
Regards,
Artem
ChangeLog:
v1:
* https://lore.kernel.org/all/20251009074443.2010699-1-a.shimko.dev@gmail.com/
v2:
* https://lore.kernel.org/all/20251009083703.2038187-1-a.shimko.dev@gmail.com/
v3:
* https://lore.kernel.org/all/20251111140935.3220840-1-a.shimko.dev@gmail.com/T/#u
v4:
* https://lore.kernel.org/all/20251111145536.3232456-1-a.shimko.dev@gmail.com/
v5:
*
* [0/2] https://lore.kernel.org/all/20260123100537.1429497-1-a.shimko.dev@gmail.com/T/#u
* [1/2] https://lore.kernel.org/all/20260123100537.1429497-2-a.shimko.dev@gmail.com/T/#u
* [2/2] https://lore.kernel.org/all/20260123100537.1429497-3-a.shimko.dev@gmail.com/T/#u
v6:
* All reset related changes have been carried over to Patch 1
Artem Shimko (2):
i2c: designware-platdrv: simplify reset control
i2c: designware-platdrv: fix cleanup on probe failure
drivers/i2c/busses/i2c-designware-platdrv.c | 41 +++++++--------------
1 file changed, 13 insertions(+), 28 deletions(-)
--
2.43.0
next reply other threads:[~2026-01-30 11:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 11:10 Artem Shimko [this message]
2026-01-30 11:10 ` [PATCH v6 1/2] i2c: designware-platdrv: simplify reset control Artem Shimko
2026-02-02 9:21 ` Mika Westerberg
2026-02-04 1:43 ` Andi Shyti
2026-02-04 1:50 ` Andy Shevchenko
2026-02-05 7:57 ` Artem Shimko
2026-02-05 7:56 ` Artem Shimko
2026-02-05 10:27 ` Andi Shyti
2026-02-05 10:56 ` Artem Shimko
2026-01-30 11:10 ` [PATCH v6 2/2] i2c: designware-platdrv: fix cleanup on probe failure Artem Shimko
2026-02-02 9:22 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260130111039.874548-1-a.shimko.dev@gmail.com \
--to=a.shimko.dev@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox