public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: correctmost <cmlists@sent.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	dmaengine@vger.kernel.org, regressions@lists.linux.dev,
	vkoul@kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [REGRESSION][BISECTED] Lenovo IdeaPad touchpad does not work when idma64 is present in initramfs
Date: Wed, 4 Feb 2026 16:34:02 +0100	[thread overview]
Message-ID: <20260204153402.GR2275908@black.igk.intel.com> (raw)
In-Reply-To: <72c71247-8b54-4820-b25d-34f659e7f957@app.fastmail.com>

On Wed, Feb 04, 2026 at 10:12:57AM -0500, correctmost wrote:
> > I will try to debug the config issue and retest the touchpad with the 
> > proper config changes.
> 
> After fixing the config issue, I now see "Dynamic Preempt: voluntary" in
> the dmesg output.  I also see "# CONFIG_HID_BPF is not set" in
> /proc/config.gz.
> 
> The "probe with driver hid-generic failed with error -22" message is
> still present and the touchpad doesn't work (full log attached).

Thanks!

I don't see any other way than adding even more debug. It really should at
least be able to parse the report descriptor as that's exactly the same as
in working case but let's try to figure why it fails. Can you add again on
top of everything this one:

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index a5b3a8ca2fcb..0a6e373bf899 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1282,6 +1282,8 @@ int hid_open_report(struct hid_device *device)
 		return -ENODEV;
 	size = device->bpf_rsize;
 
+	hid_info(device, "open_report, start %p, size %d\n", start, size);
+
 	if (device->driver->report_fixup) {
 		/*
 		 * device->driver->report_fixup() needs to work
@@ -1304,6 +1306,8 @@ int hid_open_report(struct hid_device *device)
 		kfree(buf);
 		if (start == NULL)
 			return -ENOMEM;
+
+		hid_info(device, "open_report fixup, start %p, size %d\n", start, size);
 	}
 
 	device->rdesc = start;
@@ -1333,6 +1337,8 @@ int hid_open_report(struct hid_device *device)
 	while ((next = fetch_item(start, end, &item)) != NULL) {
 		start = next;
 
+		hid_info(device, "parsing, start %p", start);
+
 		if (item.format != HID_ITEM_FORMAT_SHORT) {
 			hid_err(device, "unexpected long global item\n");
 			goto err;
@@ -2736,6 +2742,8 @@ static int __hid_device_probe(struct hid_device *hdev, struct hid_driver *hdrv)
 	const struct hid_device_id *id;
 	int ret;
 
+	hid_info(hdev, "probe starts\n");
+
 	if (!hdev->bpf_rsize) {
 		/* we keep a reference to the currently scanned report descriptor */
 		const __u8  *original_rdesc = hdev->bpf_rdesc;
@@ -2753,6 +2761,8 @@ static int __hid_device_probe(struct hid_device *hdev, struct hid_driver *hdrv)
 		hdev->bpf_rdesc = call_hid_bpf_rdesc_fixup(hdev, hdev->dev_rdesc,
 							   &hdev->bpf_rsize);
 
+		hid_info(hdev, "new rdesc %p size %d", hdev->bpf_rdesc, hdev->bpf_rsize);
+
 		/* the report descriptor changed, we need to re-scan it */
 		if (original_rdesc != hdev->bpf_rdesc) {
 			hdev->group = 0;
diff --git a/drivers/hid/hid-generic.c b/drivers/hid/hid-generic.c
index c2de916747de..63ea9c0c6ce1 100644
--- a/drivers/hid/hid-generic.c
+++ b/drivers/hid/hid-generic.c
@@ -63,6 +63,8 @@ static int hid_generic_probe(struct hid_device *hdev,
 
 	hdev->quirks |= HID_QUIRK_INPUT_PER_APP;
 
+	hid_info(hdev, "generic probe\n");
+
 	ret = hid_parse(hdev);
 	if (ret)
 		return ret;
diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
index 5a183af3d5c6..99a12ef970bd 100644
--- a/drivers/hid/i2c-hid/i2c-hid-core.c
+++ b/drivers/hid/i2c-hid/i2c-hid-core.c
@@ -800,6 +800,8 @@ static int i2c_hid_parse(struct hid_device *hid)
 	if (ret)
 		dbg_hid("parsing report descriptor failed\n");
 
+	i2c_hid_dbg(ihid, "Report Descriptor %p, size %d\n", rdesc, rsize);
+
 out:
 	if (!use_override)
 		kfree(rdesc);

  reply	other threads:[~2026-02-04 15:34 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16 17:57 [REGRESSION][BISECTED] Lenovo IdeaPad touchpad does not work when idma64 is present in initramfs correctmost
2026-01-12 14:35 ` Andy Shevchenko
2026-01-12 16:52   ` Andy Shevchenko
2026-01-15 22:50   ` correctmost
2026-01-16 10:03     ` Andy Shevchenko
2026-01-16 10:35       ` Andy Shevchenko
2026-01-17  0:25         ` correctmost
2026-01-19 10:39           ` Andy Shevchenko
2026-01-19 10:49             ` Andy Shevchenko
2026-01-20  9:33               ` Andy Shevchenko
2026-01-21  4:56                 ` correctmost
2026-01-21  9:13                   ` Andy Shevchenko
2026-01-21 13:58                     ` Mika Westerberg
2026-01-21 14:54                       ` Andy Shevchenko
2026-01-21 15:02                         ` Mika Westerberg
2026-01-21 15:19                           ` Andy Shevchenko
2026-01-22 11:00                             ` Mika Westerberg
2026-01-22 22:29                               ` correctmost
2026-01-23  6:36                                 ` Mika Westerberg
2026-01-25  3:38                                   ` correctmost
2026-01-26 13:53                                     ` Mika Westerberg
2026-01-27  6:52                                       ` correctmost
2026-01-27  8:42                                         ` Mika Westerberg
2026-01-27 10:11                                           ` correctmost
2026-01-27 10:19                                             ` Mika Westerberg
2026-01-27 10:56                                               ` correctmost
2026-01-27 14:43                                                 ` Mika Westerberg
2026-01-27 15:09                                                   ` Andy Shevchenko
2026-01-28  3:06                                                   ` correctmost
2026-01-23  6:53                                 ` Andy Shevchenko
2026-01-28  9:34                   ` Andy Shevchenko
2026-01-28 10:21                     ` correctmost
2026-01-28 12:31                       ` Mika Westerberg
2026-01-29  4:54                         ` correctmost
2026-01-29  6:58                           ` Mika Westerberg
2026-01-29  7:20                             ` correctmost
2026-01-29 11:56                               ` Mika Westerberg
2026-01-29 13:06                                 ` correctmost
2026-01-30  7:26                                   ` Mika Westerberg
2026-01-30  8:18                                     ` correctmost
2026-02-02  7:51                                       ` Mika Westerberg
2026-02-02  8:38                                         ` correctmost
2026-02-02 10:22                                           ` Mika Westerberg
2026-02-02 11:16                                             ` correctmost
2026-02-03 10:04                                               ` Mika Westerberg
2026-02-03 12:39                                                 ` correctmost
2026-02-04 12:31                                                   ` Mika Westerberg
2026-02-04 13:11                                                     ` correctmost
2026-02-04 13:19                                                       ` Andy Shevchenko
2026-02-04 14:01                                                         ` correctmost
2026-02-04 15:12                                                           ` correctmost
2026-02-04 15:34                                                             ` Mika Westerberg [this message]
2026-02-04 15:53                                                               ` correctmost
2026-02-05 10:31                                                                 ` Mika Westerberg
2026-02-14 20:17                                                                   ` correctmost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260204153402.GR2275908@black.igk.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=cmlists@sent.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox