From: Tinsae Tadesse <tinsaetadesse2015@gmail.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Jean Delvare <jdelvare@suse.com>,
Andi Shyti <andi.shyti@kernel.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: Tinsae Tadesse <tinsaetadesse2015@gmail.com>,
linux-i2c@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] hwmon: spd5118: Fail probe if SPD writes are disabled
Date: Thu, 5 Feb 2026 13:29:25 +0300 [thread overview]
Message-ID: <20260205102942.28745-3-tinsaetadesse2015@gmail.com> (raw)
In-Reply-To: <20260205102942.28745-1-tinsaetadesse2015@gmail.com>
SPD5118 requires write access for page selection, configuration,
and cache synchronization during suspend/resume. If the host
controller does not allow SPD writes, the driver cannot function
properly.
Detect this state using adapter quirks and determine whether to
stop the probe.
Signed-off-by: Tinsae Tadesse <tinsaetadesse2015@gmail.com>
---
drivers/hwmon/spd5118.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/hwmon/spd5118.c b/drivers/hwmon/spd5118.c
index 5da44571b6a0..094d05472562 100644
--- a/drivers/hwmon/spd5118.c
+++ b/drivers/hwmon/spd5118.c
@@ -525,6 +525,8 @@ static int spd5118_common_probe(struct device *dev, struct regmap *regmap,
unsigned int capability, revision, vendor, bank;
struct spd5118_data *data;
struct device *hwmon_dev;
+ struct i2c_client *client;
+ const struct i2c_adapter_quirks *quirks;
int err;
data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
@@ -552,6 +554,19 @@ static int spd5118_common_probe(struct device *dev, struct regmap *regmap,
if (!spd5118_vendor_valid(bank, vendor))
return -ENODEV;
+ /*
+ * SPD5118 requires write access for correct operation
+ * (page selection, configuration, and suspend/resume cache sync).
+ * If the SPD writes are blocked by the SMBus controller, the
+ * probe fails.
+ */
+ client = to_i2c_client(dev);
+ quirks = client->adapter->quirks;
+ if (quirks && (quirks->flags & I2C_AQ_SPD_WRITE_DISABLED)) {
+ dev_err_probe(dev, -ENODEV, "SPD Write Disable is set on adapter; refusing probe\n");
+ return -ENODEV;
+ }
+
data->regmap = regmap;
mutex_init(&data->nvmem_lock);
dev_set_drvdata(dev, data);
--
2.52.0
next prev parent reply other threads:[~2026-02-05 10:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 10:29 [PATCH 0/2] i2c: i801: Detect SPD Write Disable and expose as adapter quirk Tinsae Tadesse
2026-02-05 10:29 ` [PATCH 1/2] " Tinsae Tadesse
2026-02-05 10:29 ` Tinsae Tadesse [this message]
2026-02-05 13:46 ` [PATCH 2/2] hwmon: spd5118: Fail probe if SPD writes are disabled Guenter Roeck
2026-02-21 9:57 ` [PATCH 0/2] i2c: i801: Detect SPD Write Disable and expose as adapter quirk TINSAE TADESSE
2026-04-21 17:56 ` Mark Pearson
2026-04-23 11:21 ` TINSAE TADESSE
2026-05-04 21:41 ` Mark Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260205102942.28745-3-tinsaetadesse2015@gmail.com \
--to=tinsaetadesse2015@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox