From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Moritz Fischer <moritzf@google.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
mdf@kernel.org, ovt@google.com, Jan Dabros <jsd@semihalf.com>
Subject: Re: [PATCH] i2c: designware: Add a new ACPI HID for GOOG5000 I2C controller
Date: Mon, 2 Mar 2026 06:37:38 +0100 [thread overview]
Message-ID: <20260302053738.GO2275908@black.igk.intel.com> (raw)
In-Reply-To: <aaLH0wYeUki0jqGc@ashevche-desk.local>
On Sat, Feb 28, 2026 at 12:47:47PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 27, 2026 at 09:52:48PM +0000, Moritz Fischer wrote:
> > On Fri, Feb 27, 2026 at 08:51:26PM +0200, Andy Shevchenko wrote:
> > > On Fri, Feb 27, 2026 at 06:23:07PM +0000, Moritz Fischer wrote:
> > > > Define a new ACPI HID for GOOG5000 as used on Google Axion.
> > > >
> > > > This has been validated on Silicon.
> >
> > > > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > > > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > Cc: Jan Dabros <jsd@semihalf.com>
> >
> > > Please, put Cc list...
> >
> > > > Signed-off-by: Moritz Fischer <moritzf@google.com>
> > > > ---
> >
> > > ...somewhere here. It will have the same effect on the email. But the
> > > positive
> > > outcome is the noise reduction in the commit message.
> >
> > > See also this discussion (patch 18 subthread):
> > > https://lore.kernel.org/lkml/20260123113708.416727-19-bigeasy@linutronix.de/
> >
> > Ok, fair. Do you want me to resend or do you want to patch it when
> > applying?
>
> I'm not a maintainer, so from my p.o.v. the safest option is to send a new
> version with all data gathered and put properly (Cc list, ACPI excerpt, et
> cetera) in one place.
I don't think the excerpt adds any real value. Only thing that really
matters is that the ACPI ID is "correct" meaning that it is properly
assigned by the owner and that's true here. For the CC list does not matter
to me but if you want to resend with that fixed no problem.
Either way,
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2026-03-02 5:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 18:23 [PATCH] i2c: designware: Add a new ACPI HID for GOOG5000 I2C controller Moritz Fischer
2026-02-27 18:51 ` Andy Shevchenko
2026-02-27 21:52 ` Moritz Fischer
2026-02-28 10:47 ` Andy Shevchenko
2026-03-02 5:37 ` Mika Westerberg [this message]
2026-03-02 7:51 ` Andy Shevchenko
2026-03-02 20:39 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260302053738.GO2275908@black.igk.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=moritzf@google.com \
--cc=ovt@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox