[PATCH] i2c: designware: Add a new ACPI HID for GOOG5000 I2C controller

[PATCH] i2c: designware: Add a new ACPI HID for GOOG5000 I2C controller

[Moritz Fischer]

Define a new ACPI HID for GOOG5000 as used on Google Axion.

This has been validated on Silicon.

Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jan Dabros <jsd@semihalf.com>
Signed-off-by: Moritz Fischer <moritzf@google.com>
---
 drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index 426ffec06e22..3351c4a9ef11 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -268,6 +268,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
 	{ "AMDI0510", 0 },
 	{ "APMC0D0F", 0 },
 	{ "FUJI200B", 0 },
+	{ "GOOG5000", 0 },
 	{ "HISI02A1", 0 },
 	{ "HISI02A2", 0 },
 	{ "HISI02A3", 0 },
-- 
2.53.0.473.g4a7958ca14-goog

Re: [PATCH] i2c: designware: Add a new ACPI HID for GOOG5000 I2C controller

[Andy Shevchenko]

On Fri, Feb 27, 2026 at 06:23:07PM +0000, Moritz Fischer wrote:
> Define a new ACPI HID for GOOG5000 as used on Google Axion.
> 
> This has been validated on Silicon.

> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Jan Dabros <jsd@semihalf.com>

Please, put Cc list...

> Signed-off-by: Moritz Fischer <moritzf@google.com>
> ---

...somewhere here. It will have the same effect on the email. But the positive
outcome is the noise reduction in the commit message.

See also this discussion (patch 18 subthread):
https://lore.kernel.org/lkml/20260123113708.416727-19-bigeasy@linutronix.de/

>  drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
>  1 file changed, 1 insertion(+)

...

> +	{ "GOOG5000", 0 },

The ID seems legit, but we need an ACPI excerpt from DSDT to show how it's
described (just important pieces of the respective Device() object) and better
reference to the device / platform in question: Is it already on the market?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] i2c: designware: Add a new ACPI HID for GOOG5000 I2C controller

[Moritz Fischer]

Hi Andy,

On Fri, Feb 27, 2026 at 08:51:26PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 27, 2026 at 06:23:07PM +0000, Moritz Fischer wrote:
> > Define a new ACPI HID for GOOG5000 as used on Google Axion.
> >
> > This has been validated on Silicon.

> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Cc: Jan Dabros <jsd@semihalf.com>

> Please, put Cc list...

> > Signed-off-by: Moritz Fischer <moritzf@google.com>
> > ---

> ...somewhere here. It will have the same effect on the email. But the  
> positive
> outcome is the noise reduction in the commit message.

> See also this discussion (patch 18 subthread):
> https://lore.kernel.org/lkml/20260123113708.416727-19-bigeasy@linutronix.de/

Ok, fair. Do you want me to resend or do you want to patch it when
applying?

> >  drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
> >  1 file changed, 1 insertion(+)

> ...

> > +	{ "GOOG5000", 0 },

> The ID seems legit, but we need an ACPI excerpt from DSDT to show how it's
> described (just important pieces of the respective Device() object) and  
> better
> reference to the device / platform in question: Is it already on the  
> market?

I pulled this out of the EDK2 code, I hope this satisfies your request.

     Device (I2C0)
     {
       Name (_HID, "GOOG5000")
       Name (_UID, 0x00)
       Method (_STA) {
         Return (0xf)
       }
       Name (_CRS, ResourceTemplate ()
       {
         QWordMemory (
           ResourceProducer,
           PosDecode,
           MinFixed,
           MaxFixed,
           NonCacheable,
           ReadWrite,
           0x0,
           0xA02048000,
           0xA020480FF,
           0x000000000,
           0x000000100
         )
         Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive)
	{
           109
         }
       })
       ...
     }

This is being used by SoCs powering Google's Axion product line.

I can't go into more details on timelines etc, but they *are* real
products.

Thanks,
Moritz

> --
> With Best Regards,
> Andy Shevchenko

Re: [PATCH] i2c: designware: Add a new ACPI HID for GOOG5000 I2C controller

[Andy Shevchenko]

On Fri, Feb 27, 2026 at 09:52:48PM +0000, Moritz Fischer wrote:
> On Fri, Feb 27, 2026 at 08:51:26PM +0200, Andy Shevchenko wrote:
> > On Fri, Feb 27, 2026 at 06:23:07PM +0000, Moritz Fischer wrote:
> > > Define a new ACPI HID for GOOG5000 as used on Google Axion.
> > >
> > > This has been validated on Silicon.
> 
> > > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > Cc: Jan Dabros <jsd@semihalf.com>
> 
> > Please, put Cc list...
> 
> > > Signed-off-by: Moritz Fischer <moritzf@google.com>
> > > ---
> 
> > ...somewhere here. It will have the same effect on the email. But the
> > positive
> > outcome is the noise reduction in the commit message.
> 
> > See also this discussion (patch 18 subthread):
> > https://lore.kernel.org/lkml/20260123113708.416727-19-bigeasy@linutronix.de/
> 
> Ok, fair. Do you want me to resend or do you want to patch it when
> applying?

I'm not a maintainer, so from my p.o.v. the safest option is to send a new
version with all data gathered and put properly (Cc list, ACPI excerpt, et
cetera) in one place.

...

> > > +	{ "GOOG5000", 0 },
> 
> > The ID seems legit, but we need an ACPI excerpt from DSDT to show how it's
> > described (just important pieces of the respective Device() object) and
> > better
> > reference to the device / platform in question: Is it already on the
> > market?
> 
> I pulled this out of the EDK2 code, I hope this satisfies your request.
> 
>     Device (I2C0)
>     {
>       Name (_HID, "GOOG5000")
>       Name (_UID, 0x00)
>       Method (_STA) {
>         Return (0xf)
>       }
>       Name (_CRS, ResourceTemplate ()
>       {
>         QWordMemory (
>           ResourceProducer,
>           PosDecode,
>           MinFixed,
>           MaxFixed,
>           NonCacheable,
>           ReadWrite,
>           0x0,
>           0xA02048000,
>           0xA020480FF,
>           0x000000000,
>           0x000000100
>         )
>         Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive)
> 	{
>           109
>         }
>       })
>       ...
>     }
> 
> This is being used by SoCs powering Google's Axion product line.
> 
> I can't go into more details on timelines etc, but they *are* real
> products.

Good, just collect summary of this with the ACPI excerpt in the comment field
(after '---' line) in a new version, so we will have it for the record in the
ML archive in one place.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] i2c: designware: Add a new ACPI HID for GOOG5000 I2C controller

[Mika Westerberg]

On Sat, Feb 28, 2026 at 12:47:47PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 27, 2026 at 09:52:48PM +0000, Moritz Fischer wrote:
> > On Fri, Feb 27, 2026 at 08:51:26PM +0200, Andy Shevchenko wrote:
> > > On Fri, Feb 27, 2026 at 06:23:07PM +0000, Moritz Fischer wrote:
> > > > Define a new ACPI HID for GOOG5000 as used on Google Axion.
> > > >
> > > > This has been validated on Silicon.
> > 
> > > > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > > > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > Cc: Jan Dabros <jsd@semihalf.com>
> > 
> > > Please, put Cc list...
> > 
> > > > Signed-off-by: Moritz Fischer <moritzf@google.com>
> > > > ---
> > 
> > > ...somewhere here. It will have the same effect on the email. But the
> > > positive
> > > outcome is the noise reduction in the commit message.
> > 
> > > See also this discussion (patch 18 subthread):
> > > https://lore.kernel.org/lkml/20260123113708.416727-19-bigeasy@linutronix.de/
> > 
> > Ok, fair. Do you want me to resend or do you want to patch it when
> > applying?
> 
> I'm not a maintainer, so from my p.o.v. the safest option is to send a new
> version with all data gathered and put properly (Cc list, ACPI excerpt, et
> cetera) in one place.

I don't think the excerpt adds any real value. Only thing that really
matters is that the ACPI ID is "correct" meaning that it is properly
assigned by the owner and that's true here. For the CC list does not matter
to me but if you want to resend with that fixed no problem.

Either way,

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Re: [PATCH] i2c: designware: Add a new ACPI HID for GOOG5000 I2C controller

[Andy Shevchenko]

On Mon, Mar 02, 2026 at 06:37:38AM +0100, Mika Westerberg wrote:
> On Sat, Feb 28, 2026 at 12:47:47PM +0200, Andy Shevchenko wrote:
> > On Fri, Feb 27, 2026 at 09:52:48PM +0000, Moritz Fischer wrote:
> > > On Fri, Feb 27, 2026 at 08:51:26PM +0200, Andy Shevchenko wrote:
> > > > On Fri, Feb 27, 2026 at 06:23:07PM +0000, Moritz Fischer wrote:
> > > > > Define a new ACPI HID for GOOG5000 as used on Google Axion.
> > > > >
> > > > > This has been validated on Silicon.
> > > 
> > > > > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > > > > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > > Cc: Jan Dabros <jsd@semihalf.com>
> > > 
> > > > Please, put Cc list...
> > > 
> > > > > Signed-off-by: Moritz Fischer <moritzf@google.com>
> > > > > ---
> > > 
> > > > ...somewhere here. It will have the same effect on the email. But the
> > > > positive
> > > > outcome is the noise reduction in the commit message.
> > > 
> > > > See also this discussion (patch 18 subthread):
> > > > https://lore.kernel.org/lkml/20260123113708.416727-19-bigeasy@linutronix.de/
> > > 
> > > Ok, fair. Do you want me to resend or do you want to patch it when
> > > applying?
> > 
> > I'm not a maintainer, so from my p.o.v. the safest option is to send a new
> > version with all data gathered and put properly (Cc list, ACPI excerpt, et
> > cetera) in one place.
> 
> I don't think the excerpt adds any real value.

It doesn't per se in the commit message. I am asking to have it in the comment
block for the record (in the mailing list archives).

> Only thing that really
> matters is that the ACPI ID is "correct" meaning that it is properly
> assigned by the owner and that's true here. For the CC list does not matter
> to me but if you want to resend with that fixed no problem.
> 
> Either way,
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Thanks!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] i2c: designware: Add a new ACPI HID for GOOG5000 I2C controller

[Moritz Fischer]

On Mon, Mar 02, 2026 at 09:51:31AM +0200, Andy Shevchenko wrote:
> On Mon, Mar 02, 2026 at 06:37:38AM +0100, Mika Westerberg wrote:
> > On Sat, Feb 28, 2026 at 12:47:47PM +0200, Andy Shevchenko wrote:
> > > On Fri, Feb 27, 2026 at 09:52:48PM +0000, Moritz Fischer wrote:
> > > > On Fri, Feb 27, 2026 at 08:51:26PM +0200, Andy Shevchenko wrote:
> > > > > On Fri, Feb 27, 2026 at 06:23:07PM +0000, Moritz Fischer wrote:
> > > > > > Define a new ACPI HID for GOOG5000 as used on Google Axion.
> > > > > >
> > > > > > This has been validated on Silicon.
> > > >
> > > > > > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > > > > > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > > > Cc: Jan Dabros <jsd@semihalf.com>
> > > >
> > > > > Please, put Cc list...
> > > >
> > > > > > Signed-off-by: Moritz Fischer <moritzf@google.com>
> > > > > > ---
> > > >
> > > > > ...somewhere here. It will have the same effect on the email. But  
> the
> > > > > positive
> > > > > outcome is the noise reduction in the commit message.
> > > >
> > > > > See also this discussion (patch 18 subthread):
> > > > >  
> https://lore.kernel.org/lkml/20260123113708.416727-19-bigeasy@linutronix.de/
> > > >
> > > > Ok, fair. Do you want me to resend or do you want to patch it when
> > > > applying?
> > >
> > > I'm not a maintainer, so from my p.o.v. the safest option is to send  
> a new
> > > version with all data gathered and put properly (Cc list, ACPI  
> excerpt, et
> > > cetera) in one place.
> >
> > I don't think the excerpt adds any real value.

> It doesn't per se in the commit message. I am asking to have it in the  
> comment
> block for the record (in the mailing list archives).

Will do next time. I think now we have already a record in this thread
that'll get archived.

> > Only thing that really
> > matters is that the ACPI ID is "correct" meaning that it is properly
> > assigned by the owner and that's true here. For the CC list does not  
> matter
> > to me but if you want to resend with that fixed no problem.
> >
> > Either way,
> >
> > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Ok, will leave it as is then. Thanks

- Moritz