From: Andreas Kemnade <andreas@kemnade.info>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Frank Li <Frank.Li@nxp.com>, Linus Walleij <linusw@kernel.org>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Kalle Niemi <kaleposti@gmail.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] i2c: i2c-core-base: fix devicetree alias handling
Date: Sat, 7 Mar 2026 18:26:10 +0100 [thread overview]
Message-ID: <20260307182610.48cae8b4@kemnade.info> (raw)
In-Reply-To: <9b3c0190-7996-40a3-8306-5038f42b2b15@nvidia.com>
On Fri, 6 Mar 2026 10:18:09 +0000
Jon Hunter <jonathanh@nvidia.com> wrote:
[...]
> /sys/class/i2c-dev/i2c-0/name --> 3160000.i2c
> /sys/class/i2c-dev/i2c-1/name --> c240000.i2c
> /sys/class/i2c-dev/i2c-4/name --> Tegra BPMP I2C adapter
> /sys/class/i2c-dev/i2c-8/name --> 31e0000.i2c
>
> After this change I now see ...
>
> /sys/class/i2c-dev/i2c-9/name --> Tegra BPMP I2C adapter
> /sys/class/i2c-dev/i2c-10/name --> 3160000.i2c
> /sys/class/i2c-dev/i2c-11/name --> 31e0000.i2c
> /sys/class/i2c-dev/i2c-12/name --> c240000.i2c
>
> So the subject says that this fixes device-tree aliases, but it appears
> to break it for Tegra. In fact, this patch appears to have the same
> problem that you reported with Bartosz's change. Reverting this change
> fixes the problem. So I am a bit confused why we are seeing different
> behaviour.
>
Hmm, i2c-tegra.c was forgotten in Bartosz's change because
the code looks a bit different.
There is still
i2c_dev->adapter.dev.of_node = i2c_dev->dev->of_node;
i2c_dev->adapter.dev.parent = i2c_dev->dev;
there.
compared to
adap->parent = &pdev->dev;
adap->of_node = pdev->dev.of_node;
in omap code. So I think, the easiest to get forward is to
also adapt i2c-tegra.c.
Regards,
Andreas
next prev parent reply other threads:[~2026-03-07 17:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 17:04 [PATCH] i2c: i2c-core-base: fix devicetree alias handling Andreas Kemnade
2026-03-03 8:46 ` Bartosz Golaszewski
2026-03-04 10:47 ` Wolfram Sang
2026-03-04 16:42 ` Bartosz Golaszewski
2026-03-04 17:00 ` Wolfram Sang
2026-03-06 10:18 ` Jon Hunter
2026-03-06 14:04 ` Jon Hunter
2026-03-07 17:26 ` Andreas Kemnade [this message]
2026-03-09 9:08 ` Bartosz Golaszewski
2026-03-09 11:40 ` Wolfram Sang
-- strict thread matches above, loose matches on Subject: below --
2026-03-03 8:06 Kalle Niemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260307182610.48cae8b4@kemnade.info \
--to=andreas@kemnade.info \
--cc=Frank.Li@nxp.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=florian.fainelli@broadcom.com \
--cc=jonathanh@nvidia.com \
--cc=kaleposti@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=patrice.chotard@foss.st.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox