From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Edward Blair <edward.blair@gmail.com>
Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: acpi: skip generic I2C device when vendor-specific sibling exists
Date: Mon, 16 Mar 2026 15:45:10 +0100 [thread overview]
Message-ID: <20260316144510.GE2275908@black.igk.intel.com> (raw)
In-Reply-To: <20260316143242.24248-1-edward.blair@gmail.com>
On Mon, Mar 16, 2026 at 02:32:42PM +0000, Edward Blair wrote:
> On Sun, 16 Mar 2026 at 13:12, Mika Westerberg wrote:
> > Are they both 'present'? I mean their _STA() returns 0xF for both?
>
> MSFT8000:00 has no _STA method at all. The sysfs status attribute is
> absent, which only happens when acpi_has_method(handle, "_STA")
> returns false (device_sysfs.c line 591). So it defaults to present per
> the ACPI spec. ITE8853:00 has _STA returning 0xF.
Okay.
> As Heikki pointed out, MSFT8000 is the RhProxy device, not UCSI. My
> mistake in the commit message.
>
> > We have a quirk table already in drivers/acpi/x86/utils.c that I
> > think could be used to mark the other one being not present.
>
> That would work. acpi_device_override_status() runs before _STA
> evaluation so it can force status=0 even without a _STA method.
>
> My concern is scope. MSFT8000 is a Windows-only Resource Hub Proxy
> (RhProxy) device with no Linux driver, no module binding, and no
> in-kernel consumer. It's a static ACPI node with no _STA, so the
> BIOS exports it unconditionally. Skipping it during I2C client
> enumeration would have zero functional impact on Linux while avoiding
> a quirk table entry that needs duplicating per board.
Well it needs to be somewhere unfortunately :( Gathering these into one
file at least makes it sligthly more maintainable IMHO. I think the
override_status_ids could be made to use only the HID so no need to add DMI
strings. Of course if we ever want to bind a driver to it then it needs to
be exposed again (but that sounds unlikely since we already have a real
device that a driver could bind to).
Just my 2 cents.
next prev parent reply other threads:[~2026-03-16 14:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 1:31 [PATCH 0/2] Add UCSI I2C transport driver for ITE885x USB-C controllers Edward Blair
2026-03-14 1:31 ` [PATCH 1/2] i2c: acpi: skip generic I2C device when vendor-specific sibling exists Edward Blair
2026-03-16 13:12 ` Mika Westerberg
2026-03-16 14:32 ` Edward Blair
2026-03-16 14:45 ` Mika Westerberg [this message]
2026-03-16 15:04 ` Edward Blair
2026-03-16 14:07 ` Heikki Krogerus
2026-03-14 1:31 ` [PATCH 2/2] usb: typec: ucsi: add ITE885x I2C transport driver Edward Blair
2026-03-16 14:57 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316144510.GE2275908@black.igk.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=edward.blair@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox