Re: [PATCH v2 7/8] dt-bindings: i2c: realtek,rtl9301-i2c: extend for RTL9607C support

Rustam Adilov
2026-03-21T06:06:32Z

Hello
On 2026-03-20 13:11, Krzysztof Kozlowski wrote:
> On 20/03/2026 11:39, Rustam Adilov wrote:
>> On 2026-03-20 09:24, Krzysztof Kozlowski wrote:
>>> On Thu, Mar 19, 2026 at 10:57:52PM +0500, Rustam Adilov wrote:
>>>> Add the "realtek,rtl9607-i2c" compatible for i2c controller on the
>>>> RTL9607C SoC series.
>>>>
>>>> Add a clocks property to the properties since RTL9607C requires it
>>>> along with the realtek,scl. And because RTL9607C is the only one that
>>>
>>> My previous statement:
>>>
>>> "Other devices do not *have* any clock input?"
>>>
>>> And second one:
>>>
>>> "If devices *do not have* clock, you set it as false (see example schema
>>> and even line above!). Clue here is what I wrote "devices" and "do not
>>> have"."
>>>
>>> So why are you using completely different wording "require" with
>>> completely different implications?
>>>
>>> I did not leave any room for interpreation in my statement "If devices
>>> *do not have* clock, you set it as false".
>>
>> I apologize. I was using "require" merely to relate with "required: - property" notation used in bindings.
>>
>> Would changing the commit message to something similar in vein to [1] be better?
>>
>> [1] - https://lore.kernel.org/linux-i2c/20250927101931.71575-9-jelonek.jonas@gmail.com/
>
> It does not cover clocks and it does not answer whether devices have it
> or not.
>
> Decide first whether devices have the clock or not. I asked more than
> once last time.

I took some time to read the available docs like [1], [2] and my educated guess is, there has
to be i2c clock/s and it is most likely connected to switch core by lexra bus as the other
peripherals in SoC. I am not from Realtek so i don't know accurate that is.
The difference with RTL9300/RTL9310 and RTL9607 is just, how SCL clock of the i2c master
controller is configurable but that is for driver to deal with.

[1] - https://svanheule.net/switches/rtl93xx
[2] - https://github.com/plappermaul/realtek-doc/tree/main/datasheets

> Then write commit msg and code matching this.
>
> Best regards,
> Krzysztof

Best,
Rustam