From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rustam Adilov <adilov@disroot.org>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>,
Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 7/8] dt-bindings: i2c: realtek,rtl9301-i2c: extend for RTL9607C support
Date: Fri, 20 Mar 2026 10:24:55 +0100 [thread overview]
Message-ID: <20260320-serious-noisy-ladybug-bad92b@quoll> (raw)
In-Reply-To: <20260319175753.32338-8-adilov@disroot.org>
On Thu, Mar 19, 2026 at 10:57:52PM +0500, Rustam Adilov wrote:
> Add the "realtek,rtl9607-i2c" compatible for i2c controller on the
> RTL9607C SoC series.
>
> Add a clocks property to the properties since RTL9607C requires it
> along with the realtek,scl. And because RTL9607C is the only one that
My previous statement:
"Other devices do not *have* any clock input?"
And second one:
"If devices *do not have* clock, you set it as false (see example schema
and even line above!). Clue here is what I wrote "devices" and "do not
have"."
So why are you using completely different wording "require" with
completely different implications?
I did not leave any room for interpreation in my statement "If devices
*do not have* clock, you set it as false".
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-20 9:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 17:57 [PATCH v2 0/8] i2c: rtl9300: support for RTL9607C I2C controller Rustam Adilov
2026-03-19 17:57 ` [PATCH v2 1/8] i2c: rtl9300: split data_reg into read and write reg Rustam Adilov
2026-03-19 17:57 ` [PATCH v2 2/8] i2c: rtl9300: introduce max length property to driver data Rustam Adilov
2026-03-19 17:57 ` [PATCH v2 3/8] i2c: rtl9300: introduce F_BUSY to the reg_fields struct Rustam Adilov
2026-03-19 17:57 ` [PATCH v2 4/8] i2c: rtl9300: introduce a property for 8 bit width reg address Rustam Adilov
2026-03-19 17:57 ` [PATCH v2 5/8] i2c: rtl9300: introduce clk struct for upcoming rtl9607 support Rustam Adilov
2026-03-19 17:57 ` [PATCH v2 6/8] i2c: rtl9300: intoduce new function properties to driver data Rustam Adilov
2026-03-19 17:57 ` [PATCH v2 7/8] dt-bindings: i2c: realtek,rtl9301-i2c: extend for RTL9607C support Rustam Adilov
2026-03-20 9:24 ` Krzysztof Kozlowski [this message]
2026-03-20 10:39 ` Rustam Adilov
2026-03-20 13:11 ` Krzysztof Kozlowski
2026-03-21 6:06 ` Rustam Adilov
2026-03-21 9:58 ` Krzysztof Kozlowski
2026-03-19 17:57 ` [PATCH v2 8/8] i2c: rtl9300: add RTL9607C i2c controller support Rustam Adilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260320-serious-noisy-ladybug-bad92b@quoll \
--to=krzk@kernel.org \
--cc=adilov@disroot.org \
--cc=andi.shyti@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox