Re: [PATCH i2c-mux next 1/1] i2c: mux: Add register map based mux driver

[kernel test robot <lkp@intel.com>]

Hi Vadim,

kernel test robot noticed the following build warnings:

[auto build test WARNING on next-20260519]

url:    https://github.com/intel-lab-lkp/linux/commits/Vadim-Pasternak/i2c-mux-Add-register-map-based-mux-driver/20260520-014530
base:   next-20260519
patch link:    https://lore.kernel.org/r/20260519174310.1128423-1-vadimp%40nvidia.com
patch subject: [PATCH i2c-mux next 1/1] i2c: mux: Add register map based mux driver
config: hexagon-randconfig-r061-20260520 (https://download.01.org/0day-ci/archive/20260520/202605201604.3O39wIat-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260520/202605201604.3O39wIat-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605201604.3O39wIat-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/i2c/muxes/i2c-mux-regmap.c:121:44: warning: variable 'mux' is uninitialized when used here [-Wuninitialized]
     121 |         i2c_mux_regmap_notify_probe_abandon(pdev, mux, muxc, parent, ret,
         |                                                   ^~~
   drivers/i2c/muxes/i2c-mux-regmap.c:72:28: note: initialize the variable 'mux' to silence this warning
      72 |         struct i2c_mux_regmap *mux;
         |                                   ^
         |                                    = NULL
   1 warning generated.


vim +/mux +121 drivers/i2c/muxes/i2c-mux-regmap.c

    67	
    68	/* Probe/remove functions */
    69	static int i2c_mux_regmap_probe(struct platform_device *pdev)
    70	{
    71		struct i2c_mux_regmap_platform_data *pdata = dev_get_platdata(&pdev->dev);
    72		struct i2c_mux_regmap *mux;
    73		struct i2c_adapter *parent;
    74		struct i2c_mux_core *muxc = NULL;
    75		bool user_notify_called = false;
    76		int num, ret;
    77	
    78		if (!pdata)
    79			return -EINVAL;
    80	
    81		parent = i2c_get_adapter(pdata->parent);
    82		if (!parent)
    83			return -EPROBE_DEFER;
    84	
    85		muxc = i2c_mux_alloc(parent, &pdev->dev, pdata->num_adaps, sizeof(*mux), 0,
    86				     i2c_mux_regmap_select_chan, i2c_mux_regmap_deselect);
    87		if (!muxc) {
    88			ret = -ENOMEM;
    89			goto err_put_parent;
    90		}
    91	
    92		mux = i2c_mux_priv(muxc);
    93		memcpy(&mux->pdata, pdata, sizeof(*pdata));
    94		platform_set_drvdata(pdev, muxc);
    95		mux->last_val = -1; /* force the first selection */
    96	
    97		/* Create an adapter for each channel. */
    98		for (num = 0; num < pdata->num_adaps; num++) {
    99			ret = i2c_mux_add_adapter(muxc, 0, pdata->chan_ids[num]);
   100			if (ret)
   101				goto err_i2c_mux_add_adapter;
   102		}
   103	
   104		/* Notify caller when all channels' adapters are created. */
   105		if (pdata->completion_notify) {
   106			ret = pdata->completion_notify(pdata->handle, muxc->parent,
   107						       muxc->adapter);
   108			user_notify_called = true;
   109			if (ret)
   110				goto err_i2c_mux_add_adapter;
   111		}
   112	
   113		return 0;
   114	
   115	err_i2c_mux_add_adapter:
   116		i2c_mux_regmap_notify_probe_abandon(pdev, mux, muxc, parent, ret,
   117						    user_notify_called);
   118		i2c_mux_del_adapters(muxc);
   119		goto put_parent;
   120	err_put_parent:
 > 121		i2c_mux_regmap_notify_probe_abandon(pdev, mux, muxc, parent, ret,
   122						    user_notify_called);
   123	put_parent:
   124		i2c_put_adapter(parent);
   125	
   126		return ret;
   127	}
   128	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki