From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 773E642A160 for ; Tue, 11 Aug 2026 09:23:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786440226; cv=none; b=WE4gpKA8j4KBfDoogAwGpaONFor8HlNTAUkozw1lN5EEQYWVRwJNqKGdJBOdAKePPFcEpnb2rwyFyOYs34bSC9zQCeiq/fei79MbtcTkz0y8Dxe+vBsOMSAjFUg6Xq0AckAyL+sXm88BF4MEa4CvQwf8KRhXwHYijlO51/WkWfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786440226; c=relaxed/simple; bh=E1LSd0tr6EPYyyBJVCc5E7JVFZv4xNwNT/Cb31enh8c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IpRFBJgul4bgcAlfDGehcd07LYoJ8pA5sEtwRBYygFZq7MY8miYoX/I1zmwHHLOqiZq/3MkvM9stbvLHlMoPDCVXMJAr65eg41hIUUnMI4Ys4g/aU5O1crHKZalFf1uxwNLuUR4DwYhMVnfjht+8xHvjy8pvpYHKCDvz9bAT0EY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PBYFzT+s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UzXt1VHm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PBYFzT+s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UzXt1VHm" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67B6ul1Y2813303 for ; Tue, 11 Aug 2026 09:23:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= p3nl5AHXy/u6s86SN0NEqXaZsV1/Dw8g1zz/Exu7ZvM=; b=PBYFzT+skc0bsFsB SIrAiCcMvbO/1s+wGrVYtaymw46uURmhbaNGO/uSAh+dRkUpI/4tyedb3MibSo4N gs1v5RE3uxfAY1Av7wSncp6XAr++l7e+Ut+7x2IC7khkeoyrE9+MzIPFmiROzDob 5PWEIENWYFB8sjhLVTiHxBR5kuDZpPPbc8iVtBbyzSOPOxpVG0wR2nNA22oSKpSn +c77OyXmVFjq4+avEnxQR9P7RYl99qaxPOJltVrikiUkWrGiFqGM3kSmPIdehyHk FWXB8yperc/MPf9CsO53NdbVc440RCfmPJn5b7j1GkoqpbPuJLw54ASbbp3i0c7F QB8kmA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fyxwerk1q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 11 Aug 2026 09:23:43 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38f0fe57470so788708a91.0 for ; Tue, 11 Aug 2026 02:23:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786440222; x=1787045022; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=p3nl5AHXy/u6s86SN0NEqXaZsV1/Dw8g1zz/Exu7ZvM=; b=UzXt1VHmf6ZEgA7kU58Veblgkm9K2knZxnXCKfAUMXb/7n8087CTLLbpscdpFG5nua wL0HYooayMWKCrTPwFG772dlCbMDpQLAuQMxHFOxx69OFcGC6+ZqZngCyACNZ8lHFaj4 X8BJCq4gakut6BeEtq5JOjF9x7Uoa31i6O7JfagRmuAu62Lyana8Z19jWE1CUmrnle8i f43QBQtu/z+tDPiLiorFI/eNQIvUXSYgM99HTiDCsyoArJwO/c1K9USKhbSEjA6aubrr VrJg/kAWLN7iBjXuLdeeBXhzIO4Vp6YlzOlD/RyzPvEP+ddFpKkA/v8Pmwt6iPYIuHdp hnwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786440222; x=1787045022; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=p3nl5AHXy/u6s86SN0NEqXaZsV1/Dw8g1zz/Exu7ZvM=; b=VABraYbEeDDOhaYzIl+SuvigNhTGzldZajOFrLIE6x5EmNynJN351HWGaW6kCwK6xA coSnG7s/k5DHPW1yZcYPA4gdEejsmdFncv9IdS8IB/lVlceEwewnxhG1HuSfnmvAa4vl rArbcnp5oHkCS/Y5KMKBlhLqCt2dmpTcD5LCOiSI7yo9F3Z2RXGq9ilCA9xq41377Lm+ xnRsz7JqBIt7mWxuFMP24OGrvvxhjHCJxnrt/zZYd2hHuTt/y0y7YSlzq05EuIKwdUio LCRGCiSWkZiCxu5aJ6ogtB3xr524NI4lL0W1oRq+83nOEf3tu8VYyyLTQKGT51QgcRCi iTKg== X-Forwarded-Encrypted: i=1; AHgh+RphhJPmvBKFap50i56lSNd1ip+733wdSeYLqjlrWTax2J7pO/DU2Pvf6eaxIVdSMtp2GD6tsm+Fjjg=@vger.kernel.org X-Gm-Message-State: AOJu0YwBeiwkENG8SlCGZIqV30UMesXYifIvl4x2Ruy8kTDsRTLR1keF jmMkP3g/Ov/r3pBXYVgDj/PbbT4SOjy7qTS/a+DGFjtfm3fwEXJ5Chw4SBzjLt3WT1TViSFaq9M +elw6yKvx4x5SbxHIym6OUxhPOB4JxQLL8vHTNZppMc+8StWxDAb12f81ljK1wbux2QI3dgE= X-Gm-Gg: AR+sD12IUxKii1/RkCOdqWp8EQyP26EF+Xig18aN7nSF2CgiR98AIaBtglwMEzKtRNo bfd/KuOBtz9QXUQQfHJyWouwhlrxydXtgZtOFdncCO+A2Cr02k5fFT8AwY/qOQzA/qm4jN+nyTb e/NQsmhXhJs+I33/k5t01RyfUegPZwvHWVa8QxCspVjIhhSlqglCWUwrFH/bey0mRutZamVPj/I y1txx+JnckZKu7iY3I45mWulxlxb/T8AELrNxKptSmNnAh5mapmSj6Py6hCW1oAS+5ThrUZIe+c AdtUWJw3kKc6bGjRY46lgputwlQDa3fsphMtEWoPFJ8qyeI+XQZwaAPkF/z/dsTIEEm3sCJnXgJ bfS0hBqJ8W0A0QN8ELHHwa0qPwqxkMwE4CG4plslXqT9/aKRyFY2Rci6d+YcVlFLoPg2x7do4f3 96aFvRACP86HCIckWqUXUfB/im5aLWTBuAShE= X-Received: by 2002:a17:90b:390c:b0:38f:a81:15b1 with SMTP id 98e67ed59e1d1-392ed1ec024mr982910a91.19.1786440222296; Tue, 11 Aug 2026 02:23:42 -0700 (PDT) X-Received: by 2002:a17:90b:390c:b0:38f:a81:15b1 with SMTP id 98e67ed59e1d1-392ed1ec024mr982878a91.19.1786440221838; Tue, 11 Aug 2026 02:23:41 -0700 (PDT) Received: from hu-kathirav-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-14120447d8esm3385004c88.14.2026.08.11.02.23.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 02:23:41 -0700 (PDT) From: Kathiravan Thirumoorthy Date: Tue, 11 Aug 2026 14:53:17 +0530 Subject: [PATCH 2/2] i2c: qcom-geni: Add I2C frequency table for firmware-based SEs Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260811-ipq5424_i2c_scl_updates-v1-2-bddcb2ceebda@oss.qualcomm.com> References: <20260811-ipq5424_i2c_scl_updates-v1-0-bddcb2ceebda@oss.qualcomm.com> In-Reply-To: <20260811-ipq5424_i2c_scl_updates-v1-0-bddcb2ceebda@oss.qualcomm.com> To: Mukesh Kumar Savaliya , Viken Dadhaniya , Andi Shyti , Manikanta Mylavarapu , Bjorn Andersson , Konrad Dybcio Cc: Mukesh Kumar Savaliya , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Kathiravan Thirumoorthy X-Mailer: b4 0.15.2 X-Proofpoint-GUID: 3pUG35G7WsGi-TNUnItxK-2D2ZMNmcwu X-Authority-Analysis: v=2.4 cv=K8QS2SWI c=1 sm=1 tr=0 ts=6a7aea1f cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=gRDuyahOx82SaJh1DHAA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: 3pUG35G7WsGi-TNUnItxK-2D2ZMNmcwu X-Proofpoint-Spam-Info: AW1haW4tMjYwODExMDA3NyBTYWx0ZWRfX7GWVWXf9mFNl jDSK+KM+qVANiOXLrciIes4Lshfege3MWkoR1IbCmkTdatj2VTfcmz7Yenpb1E/mgzMN6SVJFF4 Kuw2dbdPbRqTRf97sF+alNw67LgNiFE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODExMDA3NyBTYWx0ZWRfX+3BRsk8fsn45 WK6nV7YNbcR4/CMFx6l8zxZ616q88Up+OzbsdIZwrJ28/uixBeGnxhcyOx07ZxVZARq3UweWMFD SADUBsAIDqnIwIAcVYIho5B3TJ0+AKdRJcDqmBUQQGXILy8jjE0sUvJ48rEkra9Ov++hAk4moct JWQu7yOtwIRVbnYLkJarY19GDo9HP7AP4vDWQUTJKbG/yypDnK/u1FQ0W18Q+gcl6jE4gNNQhs+ YV2wHSPUBx6yjKiwX7A/Ou5WpJpwLlae+0hhZ86bsmiqGTADLy09fuMcODNCom558w3EZCu+rpd q1c2KZJgBmVY4nGu4bjFO6v2rXg7QmQNZEunrQ5ZmDMmT0w3KKczq6T2sr9k6QgtM5WP8uBTQC7 4J5aBSKyjSVIVQ9Zh1mbiL00yzMSnuSl7rP/D6P2PSFqMrb5x0+UP2uHBmr6G/K1BVS1HH0kHWc dwXk4lFtMfud521EYZQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_06,2026-08-10_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 spamscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608110077 On IPQ5424, RTL-based I2C can be supported by both minicore and firmware based SEs. For firmware-based SEs, use different SCL settings as recommended by the design team. Introduce a separate table for the same. Identify whether the SE is minicore or firmware-based and select the appropriate frequency table to achieve the desired bus frequencies. Move geni_i2c_clk_map_idx() from geni_i2c_resources_init() to geni_i2c_init() to ensure SE_HW_PARAM_2 is accessed only after the required clocks have been enabled. Signed-off-by: Kathiravan Thirumoorthy --- drivers/i2c/busses/i2c-qcom-geni.c | 23 +++++++++++++++++------ include/linux/soc/qcom/geni-se.h | 1 + 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c index 00013b41a6f5..2f3026602c0c 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -194,12 +194,21 @@ static const struct geni_i2c_clk_fld geni_i2c_clk_map_32mhz[] = { {} }; +static const struct geni_i2c_clk_fld geni_i2c_clk_map_32mhz_fwcore[] = { + { I2C_MAX_STANDARD_MODE_FREQ, 12, 9, 10, 25 }, + { I2C_MAX_FAST_MODE_FREQ, 4, 3, 9, 18 }, + { I2C_MAX_FAST_MODE_PLUS_FREQ, 1, 6, 15, 29 }, + {} +}; + static int geni_i2c_clk_map_idx(struct geni_i2c_dev *gi2c) { const struct geni_i2c_clk_fld *itr; + bool is_minicore = FIELD_GET(GEN_USE_MINICORES, + readl_relaxed(gi2c->se.base + SE_HW_PARAM_2)); if (clk_get_rate(gi2c->se.clk) == 32 * HZ_PER_MHZ) - itr = geni_i2c_clk_map_32mhz; + itr = is_minicore ? geni_i2c_clk_map_32mhz : geni_i2c_clk_map_32mhz_fwcore; else itr = geni_i2c_clk_map_19p2mhz; @@ -1046,6 +1055,13 @@ static int geni_i2c_init(struct geni_i2c_dev *gi2c) return ret; } + ret = geni_i2c_clk_map_idx(gi2c); + if (ret) { + return dev_err_probe(gi2c->se.dev, ret, "Invalid clk frequency %d Hz\n", + gi2c->clk_freq_out); + goto err; + } + proto = geni_se_read_proto(&gi2c->se); if (proto == GENI_SE_INVALID_PROTO) { ret = geni_load_se_firmware(&gi2c->se, GENI_SE_I2C); @@ -1109,11 +1125,6 @@ static int geni_i2c_resources_init(struct geni_se *se) if (ret) return ret; - ret = geni_i2c_clk_map_idx(gi2c); - if (ret) - return dev_err_probe(gi2c->se.dev, ret, "Invalid clk frequency %d Hz\n", - gi2c->clk_freq_out); - return geni_icc_set_bw_ab(&gi2c->se, GENI_DEFAULT_BW, GENI_DEFAULT_BW, Bps_to_icc(gi2c->clk_freq_out)); } diff --git a/include/linux/soc/qcom/geni-se.h b/include/linux/soc/qcom/geni-se.h index 29a53bbc0dd4..7e8c0bb6d674 100644 --- a/include/linux/soc/qcom/geni-se.h +++ b/include/linux/soc/qcom/geni-se.h @@ -331,6 +331,7 @@ struct geni_se { #define RX_FIFO_DEPTH_SHFT 16 /* SE_HW_PARAM_2 fields */ +#define GEN_USE_MINICORES BIT(12) #define PROG_RAM_DEPTH_MSK GENMASK(10, 0) #define HW_VER_MAJOR_MASK GENMASK(31, 28) -- 2.34.1