From: Liu Zhenlong <dragonliu2018@gmail.com>
To: vladimir.zapolskiy@linaro.org
Cc: linux-i2c@vger.kernel.org, konrad.dybcio@oss.qualcomm.com
Subject: Re: [PATCH v2] i2c: qcom-cci: fix device_node refcount leak in cci_probe()/cci_remove()
Date: Wed, 19 Aug 2026 11:03:54 +0800 [thread overview]
Message-ID: <20260819030354.49170-1-dragonliu2018@gmail.com> (raw)
In-Reply-To: <db94c578-2bfb-4297-9955-fba690ecfe39@linaro.org>
Hi Vladimir,
Thanks for the review and the Reviewed-by!
On the cast: I considered (void (*)(void *))of_node_put, but kept the
small wrapper. Casting to an incompatible function pointer type and
calling through it is technically undefined, and tegra_dc_of_node_put()
in drivers/gpu/drm/tegra/rgb.c uses the same one-line wrapper around
of_node_put(), so I followed that existing pattern. Happy to switch
to the cast if you'd still prefer it.
Regards,
Liu Zhenlong
prev parent reply other threads:[~2026-08-19 3:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-15 14:09 [PATCH] i2c: qcom-cci: fix device_node refcount leak in cci_probe()/cci_remove() Liu Zhenlong
2026-08-18 11:41 ` Konrad Dybcio
2026-08-18 17:57 ` [PATCH v2] " Liu Zhenlong
2026-08-18 23:18 ` Vladimir Zapolskiy
2026-08-19 3:03 ` Liu Zhenlong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819030354.49170-1-dragonliu2018@gmail.com \
--to=dragonliu2018@gmail.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-i2c@vger.kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox