From: Triet Hoang <triet.hoang.dev@gmail.com>
To: andi.shyti@kernel.org
Cc: bence98@sch.bme.hu, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, triet.hoang.dev@gmail.com
Subject: Re: [PATCH v2] i2c: cp2615: handle allocation failure
Date: Sat, 29 Aug 2026 10:42:20 +0700 [thread overview]
Message-ID: <20260829034220.3053-1-triet.hoang.dev@gmail.com> (raw)
In-Reply-To: <apG_qiYtTQvt9s-y@zenone.zhora.eu>
On Fri, 28 Aug 2026 19:09:03 +0200 Andi Shyti wrote:
> Next time please don't send your v2 as in reply to v1. It
> confuses me.
Sorry about that. Will keep it in my mind!
> Your patch looks good, but, as you are at it, can I ask you here
> a little effort? Personally I don't like and I find unreadable
> the form:
>
> struct cp2615_iop_msg *msg = kzalloc_obj(*msg);
> ...
>
> if (!msg)
> return -ENOMEM.
>
> Important assignments, like kzalloc_*(), shouldn't be made during
> declaration. I prefer the form:
>
>
> struct cp2615_iop_msg *msg;
> ...
>
> msg = kzalloc_obj(*msg);
> if (!msg)
> return -ENOMEM.
>
> Works for you? Do you mind updating in v3?
Sure, no problem. I will update and send the v3.
Thanks for your reviewing and suggestion!
Regards,
Triet
prev parent reply other threads:[~2026-08-29 3:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-16 16:17 [PATCH] i2c: cp2615: handle allocation failure Triet Hoang
2026-08-18 11:17 ` [PATCH v2] " Triet Hoang
2026-08-19 6:28 ` Markus Elfring
2026-08-28 12:08 ` Bence Csókás
2026-08-28 17:09 ` Andi Shyti
2026-08-28 20:12 ` Bence Csókás
2026-08-28 17:09 ` Andi Shyti
2026-08-28 20:40 ` Christophe JAILLET
2026-08-29 3:42 ` Triet Hoang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260829034220.3053-1-triet.hoang.dev@gmail.com \
--to=triet.hoang.dev@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=bence98@sch.bme.hu \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox