From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2471119049B; Sun, 30 Aug 2026 13:06:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788095179; cv=none; b=OSwwmL0djvOK7KpI7yEpxpODtZfJ7+BFAR/6iQisrtsKWybEKvAoa6w46zNR62g3FyUdQsp3NGAOrWOCIREQ5CcJ4nF2AoIBY2qHnE4qGH04wArUqyiG2X86pDJWy5JELZWRr4kk2tns2jVj0eebKXKp4jiM8um6hbtj0rGIxgs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788095179; c=relaxed/simple; bh=yp9XlnF/QYne/dRHa6riBQMBmcT18ZyLfr3TR5YqCtA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qG4+L0zMv+Sc3y7lj8e0FEbvk9zp1yzltbOGxHHU4Z+M0I5C2g413ENL6+TlgwV7vEQniYccPVtfk62cYRhL1DtsIylZ1cm5nknkOKTQtUE1uj4TXaho7ILxDzvugEtItKBWLoop+hAteq+Q8sTZE+fmb3A4FfPxt9NCTg6rz98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [111.196.241.250]) by APP-03 (Coremail) with SMTP id rQCowAAXGzm6KpRqe9GaBg--.26886S2; Sun, 30 Aug 2026 21:06:02 +0800 (CST) From: Pengpeng Hou To: Ryan Chen Cc: Pengpeng Hou , Benjamin Herrenschmidt , Joel Stanley , Andi Shyti , Andrew Jeffery , Billy Tsai , Philipp Zabel , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] i2c: aspeed: propagate reset deassert errors Date: Sun, 30 Aug 2026 21:06:00 +0800 Message-ID: <20260830130600.560-1-pengpeng@iscas.ac.cn> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:rQCowAAXGzm6KpRqe9GaBg--.26886S2 X-Coremail-Antispam: 1UD129KBjvdXoWrZw1DGFyxKw13Jw18GF4kZwb_yoWkCrXE9F 1kW3ZxXrn8CrZY9w15J3y3ZrZIkF909F1kW3WUtw1SkFyjvayUXF1DZr95Ar43Xr12gFy7 u3WYvr4fAwnrGjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb3kFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E14v26F4UJV W0owAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628v n2kIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7x kEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E 67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUCVW8Jw CI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1x MIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIda VFxhVjvjDU0xZFpf9x0JUgXocUUUUU= X-CM-SenderInfo: pshqw1xhqjqxpvfd2hldfou0/ aspeed_i2c_probe_bus() initializes and registers an adapter after deasserting its shared reset, without checking whether the reset provider accepted that transition. Do not publish an adapter whose controller may still be held in reset. Fixes: edd20e95bca4 ("i2c: aspeed: Deassert reset in probe") Signed-off-by: Pengpeng Hou --- drivers/i2c/busses/i2c-aspeed.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c index a26b74c712061..bf29719bab1ea 100644 --- a/drivers/i2c/busses/i2c-aspeed.c +++ b/drivers/i2c/busses/i2c-aspeed.c @@ -1023,7 +1023,9 @@ static int aspeed_i2c_probe_bus(struct platform_device *pdev) "missing or invalid reset controller device tree entry\n"); return PTR_ERR(bus->rst); } - reset_control_deassert(bus->rst); + ret = reset_control_deassert(bus->rst); + if (ret) + return ret; ret = of_property_read_u32(pdev->dev.of_node, "bus-frequency", &bus->bus_frequency); base-commit: 08dbfad3f5040f5bdb6c529da20d6d4e81fefd72 -- 2.50.1