From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Mika Westerberg <westeri@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
"fangzhong.zhou" <myth5@myth5.com>,
Hans de Goede <johannes.goede@oss.qualcomm.com>,
Dell.Client.Kernel@dell.com, linux-i2c@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: acpi: Limit DLL0945 100 kHz quirk to Dell Precision 5560 and XPS 15 9510
Date: Fri, 20 Nov 2026 08:19:24 +0100 [thread overview]
Message-ID: <20261120071924.GI229695@black.igk.intel.com> (raw)
In-Reply-To: <20261119143218.586632-2-pmenzel@molgen.mpg.de>
Hi,
On Thu, Nov 19, 2026 at 03:32:16PM +0100, Paul Menzel wrote:
> Commit 0b7c9528facd ("i2c: Force DLL0945 touchpad i2c freq to 100khz")
> forces the I2C bus to 100 kHz for all devices with the ACPI ID DLL0945 to
> work around a sluggish cursor on the Dell Precision 5560. But DLL0945 does
> not identify a touchpad model. Dell uses it for touchpads from different
> vendors:
>
> System Touchpad
> Dell Precision 5560 ELAN 04F3:311C
> Dell XPS 15 9510 ELAN 04F3:311C (bugzilla #214597)
> Dell XPS 13 9310 Synaptics 06CB:CDE6
>
> The ELAN touchpads are the ones known to need 100 kHz, but the Synaptics
> touchpad of the Dell XPS 13 9310 is slowed down without need. Its DSDT
> specifies 400 kHz, and Linux logs:
>
> i2c_designware i2c_designware.0: [Firmware Bug]: DSDT uses known not-working I2C bus speed 400000, forcing it to 100000
>
> The touchpad scans every 7.1 ms (scan time field in the input report), and
> i2c-hid reads wMaxInputLength (64 bytes) for each report. Tracing the I2C
> transfers for 30 seconds of moving a finger on the touchpad shows:
>
> 100 kHz 400 kHz
> read time (median) 7.3 ms 2.5 ms
> bus busy 87 % 36 %
> reports per second 111 140
> frames lost 18.6 % 0 %
>
> At 100 kHz the host cannot keep up with the touchpad, and every fifth frame
> is lost. At 400 kHz all frames arrive, and no sluggish cursor was noticed.
>
> So, only apply the DLL0945 entry on the Dell Precision 5560 and XPS 15 9510
> by pointing the entry's driver_data to a DMI table, which can be used to
> restrict other entries in the same way.
Yeah, we should really figure out how this works in Windows. I'm sure they
don't have such a quirk list so maybe it's up to the vendor specific
drivers to "tune" the bus to their needs whereas in Linux we obey the ACPI
description.
> Tested on the Dell XPS 13 9310.
>
> - The `[Firmware Bug] … forcing it to 100000` line is gone from dmesg.
> - Re-probed the touchpad’s I²C controller with debug output on, and it
> reports `Bus speed: Fast Mode (400 kHz)`. The touchpad came back up
> under hid-multitouch.
>
> Fixes: 0b7c9528facd ("i2c: Force DLL0945 touchpad i2c freq to 100khz")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=214597
> Cc: Hans de Goede <johannes.goede@oss.qualcomm.com>
> Cc: Dell.Client.Kernel@dell.com
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Acked-by: Mika Westerberg (Intel) <westeri@kernel.org>
prev parent reply other threads:[~2026-11-20 7:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 14:32 [PATCH] i2c: acpi: Limit DLL0945 100 kHz quirk to Dell Precision 5560 and XPS 15 9510 Paul Menzel
2026-11-20 7:19 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120071924.GI229695@black.igk.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Dell.Client.Kernel@dell.com \
--cc=andi.shyti@kernel.org \
--cc=johannes.goede@oss.qualcomm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myth5@myth5.com \
--cc=pmenzel@molgen.mpg.de \
--cc=westeri@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox