public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@kernel.org>, Peter Rosin <peda@axentia.se>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH] i2c: mux: reg: Remove class-based device auto-detection support
Date: Wed, 20 Dec 2023 21:58:08 +0100	[thread overview]
Message-ID: <20bf2d9b-4f36-4279-ace9-8b1bbc6286fb@gmail.com> (raw)
In-Reply-To: <ZYNSZ+OJ5wEJwoCz@shikoro>

On 20.12.2023 21:45, Wolfram Sang wrote:
> On Wed, Nov 08, 2023 at 07:38:07AM +0100, Heiner Kallweit wrote:
>> Legacy class-based device auto-detection shouldn't be used in new code.
>> Therefore remove support in i2c-mux-reg as long as we don't have a
>> user of this feature yet.
>>
>> Link: https://lore.kernel.org/linux-i2c/a22978a4-88e4-46f4-b71c-032b22321599@gmail.com/
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> 
> Applied to for-next, thanks!
> 
> I guess i2c-mux-gpio is more difficult because it has users already?
> 
Right. i801 has a special handling for certain Asus server models with
> 8 memory slots where the smbus to the SPD eeproms is gpio-muxed.
I2C_CLASS_HWMON is passed to the child adapters to probe for DIMM
thermal sensors.

For getting rid of the class-based probing we have to:
- Extend i2c_register_spd() for use on muxed smbus segments.
  Then i2c_register_spd() instantiates at24 to handle the SPD eeprom (for DDR3)
- at24 then checks the SPD for an advertised thermal sensor, and instantiates
  jc42 to handle the thermal sensor -> a patch for this has been submitted

The extension of i2c_register_spd() needs some more thoughts.


      reply	other threads:[~2023-12-20 20:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-08  6:38 [PATCH] i2c: mux: reg: Remove class-based device auto-detection support Heiner Kallweit
2023-12-19 21:44 ` Heiner Kallweit
2023-12-20 20:45 ` Wolfram Sang
2023-12-20 20:58   ` Heiner Kallweit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20bf2d9b-4f36-4279-ace9-8b1bbc6286fb@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=peda@axentia.se \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox