From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shawn Guo <shengchao.guo@oss.qualcomm.com>
Cc: Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Praveen Talari <praveen.talari@oss.qualcomm.com>,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "dt-bindings: i2c: Describe SA8255p"
Date: Tue, 7 Jul 2026 10:46:49 +0200 [thread overview]
Message-ID: <20fa0bb5-1bdd-4ea2-9266-710dbde9d4c1@kernel.org> (raw)
In-Reply-To: <aky8NoA3r7WsjLXw@QCOM-aGQu4IUr3Y>
On 07/07/2026 10:43, Shawn Guo wrote:
> On Tue, Jul 07, 2026 at 10:08:09AM +0200, Krzysztof Kozlowski wrote:
>> On 07/07/2026 10:02, Shawn Guo wrote:
>>> This reverts commit fd359c0272bb4078f3a7ef34c1d53ee0deb59900.
>>>
>>> Compatible "qcom,sa8255p-geni-i2c" had already been defined by
>>> soc/qcom/qcom,sa8255p-geni-se-qup.yaml. Revert the change to avoid the
>>> same compatible being defined by two bindings.
>>
>> This makes no sense and to prove it: are you going to revert all such
>> bindings, like 100 of them?
>
> Nord compatible "qcom,sa8797p-geni-i2c" was added to
> soc/qcom/qcom,sa8255p-geni-se-qup.yaml, as that's where Lemans compatible
> "qcom,sa8255p-geni-i2c" is defined. CHECK_DTBS has been working fine by
> matching geni-se-qup yaml.
>
> make CHECK_DTBS=y qcom/sa8797p-ride.dtb
>
> Now with this geni-i2c yaml comes in play, CHECK_DTBS finds it instead
> and starts complaining about Nord compatible missing there.
>
> DTC [C] arch/arm64/boot/dts/qcom/sa8797p-ride.dtb
> arch/arm64/boot/dts/qcom/sa8797p-ride.dtb: i2c@880000 (qcom,sa8797p-geni-i2c): compatible:0: 'qcom,sa8255p-geni-i2c' was expected
> from schema $id: http://devicetree.org/schemas/i2c/qcom,sa8255p-geni-i2c.yaml
> arch/arm64/boot/dts/qcom/sa8797p-ride.dtb: i2c@880000 (qcom,sa8797p-geni-i2c): compatible: ['qcom,sa8797p-geni-i2c', 'qcom,sa8255p-geni-i2c'] is too long
> from schema $id: http://devicetree.org/schemas/i2c/qcom,sa8255p-geni-i2c.yaml
>
> What's your suggestion to fix the problem, add Nord compatible to
> geni-se-qup yaml as well?
I don't understand what is the problem, but you also did not answer to
my question. If you answered my question, you would answer above, but in
case question was unclear so let me rephrase it: why do you revert only
this duplicated compatible but not 100 others?
Best regards,
Krzysztof
prev parent reply other threads:[~2026-07-07 8:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 8:02 [PATCH] Revert "dt-bindings: i2c: Describe SA8255p" Shawn Guo
2026-07-07 8:08 ` Krzysztof Kozlowski
2026-07-07 8:43 ` Shawn Guo
2026-07-07 8:46 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20fa0bb5-1bdd-4ea2-9266-710dbde9d4c1@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=praveen.talari@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=shengchao.guo@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox