From: Paul Burton <paul.burton@imgtec.com>
To: Jan Glauber <jan.glauber@caviumnetworks.com>
Cc: "Steven J. Hill" <Steven.Hill@cavium.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, linux-mips@linux-mips.org,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH v2 0/3] i2c: octeon: thunder: Fix i2c not working on Octeon
Date: Wed, 16 Nov 2016 10:38:55 +0000 [thread overview]
Message-ID: <21144795.sM34J9FN6K@np-p-burton> (raw)
In-Reply-To: <20161115130314.GC2772@hardcore>
[-- Attachment #1: Type: text/plain, Size: 1344 bytes --]
Hi Jan,
On Tuesday, 15 November 2016 14:03:15 GMT Jan Glauber wrote:
> On Mon, Nov 14, 2016 at 01:53:40PM -0600, Steven J. Hill wrote:
> > On 11/14/2016 12:50 PM, Jan Glauber wrote:
> > > Since time is running out for 4.9 (or might have already if you're not
> > > going to send another pull request) I'm going for the safe option
> > > to fix the Octeon i2c problems, which is:
> > >
> > > 1. Reverting the readq_poll_timeout patch since it is broken
> > > 2. Apply Patch #2 from Paul
> > > 3. Add a small fix for the recovery that makes Paul's patch
> > >
> > > work on ThunderX
> > >
> > > I'll try to come up with a better solution for 4.10. My plan is to get
> > > rid
> > > of the polling-around-interrupt thing completely, but for that we need
> > > more
> > > time to make it work on Octeon.
> > >
> > > Please consider for 4.9.
> >
> > Hey Jan.
> >
> > This does not work on Octeon 71xx platforms. I will look at it more
> > closely tomorrow.
>
> Paul, can you confirm this? It doesn't make sense for me, since patches #1
> and #3 are unlikely to break anything... And patch #2 worked for you.
For me v4.9-rc5 plus these 3 patches boots fine on a Rhino Labs UTM8 system
which previously hung whilst probing the I2C driver & devices. Feel free to
add:
Tested-by: Paul Burton <paul.burton@imgtec.com>
Thanks,
Paul
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-11-16 10:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 18:50 [PATCH v2 0/3] i2c: octeon: thunder: Fix i2c not working on Octeon Jan Glauber
2016-11-14 18:50 ` [PATCH v2 1/3] Revert "i2c: octeon: thunderx: Limit register access retries" Jan Glauber
2016-11-14 18:50 ` [PATCH v2 2/3] i2c: octeon: Fix waiting for operation completion Jan Glauber
2016-11-14 18:50 ` [PATCH v2 3/3] i2c: octeon: thunderx: TWSI software reset in recovery Jan Glauber
2016-11-14 19:53 ` [PATCH v2 0/3] i2c: octeon: thunder: Fix i2c not working on Octeon Steven J. Hill
2016-11-15 13:03 ` Jan Glauber
2016-11-16 10:38 ` Paul Burton [this message]
2016-11-22 12:01 ` Wolfram Sang
2016-11-22 14:55 ` Jan Glauber
2016-11-28 14:22 ` Wolfram Sang
2016-11-28 14:47 ` Steven J. Hill
2016-11-29 9:19 ` Jan Glauber
2016-11-29 18:22 ` Steven J. Hill
2016-11-29 18:37 ` Wolfram Sang
2016-11-29 19:10 ` Steven J. Hill
2016-11-29 19:14 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21144795.sM34J9FN6K@np-p-burton \
--to=paul.burton@imgtec.com \
--cc=Steven.Hill@cavium.com \
--cc=david.daney@cavium.com \
--cc=jan.glauber@caviumnetworks.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox