From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE7323815FF; Mon, 30 Mar 2026 07:23:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774855411; cv=none; b=Y2Tg2Y62elvDT9BrDLfrICybYyztVVT5jOLicWxPXkuyMiY7ed4XB5pcRHj9z+7tLmmlCKq7xfOC+dEJ3TDT+BdLoriXP6foWMnUUpy6nyvMTglibiRRek3azs3dQiNw4kAUIVdBcF85qOHmhRf+AAqXYGyK7REDZoG//ED50Hk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774855411; c=relaxed/simple; bh=kwNDRT9OrPmFc/hILh1ysWYBh5D2F0Zu0uy0zV4cgoY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f3rwTI2vtLawrGA2lDppGv0dg4lkO5W8X2F3pYW6DAxkFrBGR1FQZyx1owLXoXytAQQ4WzW6Ic++zD5cuUe5nUSW3YHjhK0Mu2YJBtAq1iZphLpxOeDWdhBVXlUz1LCtCuqb5L1OWfgCyL5NEoEDKin60cWP70EdpXUU7Raimro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qDvOM0cN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qDvOM0cN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F765C4CEF7; Mon, 30 Mar 2026 07:23:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774855411; bh=kwNDRT9OrPmFc/hILh1ysWYBh5D2F0Zu0uy0zV4cgoY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qDvOM0cNhw0b4IKaKQzJoOS5AJawBLxv3ayv6ZH4+d1bqMZNPzgyVHn6Jo4lse2Q6 F1OANWizgJTVAkhIYNTV8A8Mza6QArHTTBpVPsZRGYd3xiNkBWlCZm772KQMM/GKdv rW/pEyKyC9u9L1JNd2lnqgiJI+Mx04hSu34fHpee3BTwfqfsiar7BhxiPqa2zaYYtZ saoJ/+XdeqWQx2LaOK+S+2esvDtqioswiqZIK4rTYeQfjXuDInTzMubAwPnWsI2Lxf OcrjRmgZPI9dTppwMwDNLY59LHDUU26jTQIiMO/jhfBe6lf0TS8J83mhnBrrAXXNmE cgM+b6r6jZnvw== Message-ID: <2388acbc-a927-4727-a23c-5ecd7c33a926@kernel.org> Date: Mon, 30 Mar 2026 09:23:27 +0200 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] dt-bindings: i2c: ls2x-i2c: Add clock- related properties To: Hongliang Wang Cc: Binbin Zhou , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, loongarch@lists.linux.dev References: <20260325011852.19079-1-wanghongliang@loongson.cn> <20260325011852.19079-2-wanghongliang@loongson.cn> <20260325-outstanding-weasel-of-fruition-89db37@quoll> <1b5283d8-294c-86de-c3d8-bf205ac24216@loongson.cn> <0d7dfe5b-5e2d-4850-8922-16eb6bd9bcae@kernel.org> <900dc1a4-66ab-411f-8a32-4c6cf339e8ec@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 30/03/2026 09:18, Hongliang Wang wrote: > > On 2026/3/27 下午2:39, Krzysztof Kozlowski wrote: >> On 27/03/2026 04:09, Hongliang Wang wrote: >>> The initial idea was that this patch could be used for both ACPI and DTS. >>>>>> The i2c-ls2x driver is compatible with both Loongson 2K and 3A+7A >>>>>> platform, parse >>>>>> the same parameters regardless of dts or acpi parameter passing, So >>>>>> clock-input >>>>>> and clock-div attributes are defined to describe input clock of i2c >>>>>> controller and >>>>>> divisor of input clock. It can be used on both 2K and 3A+7A platform. >>>>> And you cannot use them in DTS. >>> OK >>>> I need to keep guessing what you want to achieve, because neither your >>>> message nor commit text was explicit >>> What I want to achieve is to describe the input clock and divisor of I2C >>> controller >> Input clocks are defined as clock inputs obviously in DT, not as >> integers. Bindings need to describe the hardware, so start with that. > I can describe the hardware in loongson,ls2x-i2c.yaml, and I would like to > confirm with you what final implementation plan you agree to? clock > framework > or custom clock-input an clock-div attributes? if clock framework, how > can it > also be used for ACPI? And you ask DT maintainer for that? It's not relevant. You sent DT bindings patch, so this patch must be correct and we discuss this patch here. Best regards, Krzysztof