From: Romain Gantois <romain.gantois@bootlin.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] i2c: Fix end of loop test in i2c_atr_find_mapping_by_addr()
Date: Wed, 23 Apr 2025 17:25:44 +0200 [thread overview]
Message-ID: <2427370.em1n7HOibB@fw-rgant> (raw)
In-Reply-To: <aAii_iawJdptQyCt@stanley.mountain>
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
Hello Dan,
On Wednesday, 23 April 2025 10:21:18 CEST Dan Carpenter wrote:
> When the list_for_each_entry_reverse() exits without hitting a break
> then the list cursor points to invalid memory. So this check for
> if (c2a->fixed) is checking bogus memory. Fix it by using a "found"
> variable to track if we found what we were looking for or not.
IIUC the for loop ending condition in list_for_each_entry_reverse() is
"!list_entry_is_head(pos, head, member);", so even if the loop runs to
completion, the pointer should still be valid right?
Thanks,
--
Romain Gantois, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-04-23 15:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 8:21 [PATCH next] i2c: Fix end of loop test in i2c_atr_find_mapping_by_addr() Dan Carpenter
2025-04-23 15:25 ` Romain Gantois [this message]
2025-04-23 17:29 ` Dan Carpenter
2025-04-24 6:32 ` Tomi Valkeinen
2025-04-24 7:10 ` Romain Gantois
2025-04-30 12:25 ` Luca Ceresoli
2025-05-02 14:40 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2427370.em1n7HOibB@fw-rgant \
--to=romain.gantois@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox