From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1A4429CE1; Wed, 31 Jul 2024 06:01:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722405704; cv=none; b=Pd4i6TpaPPg0jZeRSJLsumecjlm/4zKLiBMUnn3uNiaCCqhhaivH9kcexHKKDQk37c9i9EK5IrQS8UU/Tb++9nN3RKEc/oDoEzpvAUjZm0JxkxsWmtuMeYAVJBJpXmOEQJbt/y4XZXYkD5M47+rZ1qvCRAkdgqtKY8t0UUnaNrM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722405704; c=relaxed/simple; bh=F3gK9K6jM/Ut2UnX60EKOo2IsJnHumeVozR82BQmQ2I=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=S91OwS66Rue/I9raXRaw3qcwxuOaUsbtKOGFFyjz15TuDnnvUphG+GdkW8GKRPJvSShEe05+1LoqyWB4Xbt+3CsojyOPxyz5rIIbOoUcqtmwZ8O+NRHUmTlMGUpXHO1R+/sNyOPWVjBSHu9vW/hfUyVM9LRwEUByMtBwxbRPL0c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=Y+FLFMrB; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="Y+FLFMrB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1722405694; bh=gojGMfkKjsM9J6aga5vnl6TY2q5uJ85vagSCFyyceU0=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Y+FLFMrB/2bHdm2VqEOmMjhfpLWLytJyLcAfytsqz+42qV7eCWCiD31jvHFVfSzBg oK79Bo7dQNkecMYQfqjTeGSRxabnWt4RedzjaaiqrUaFFMmTay9B1P9F+zvcdvxD+F 8hYfcF3dNf9Q5mis2ti049+EYUVUXavbJM2VIUNcfQNVzjywIXyxFBsWlysEkxhspj E6JZ0hLeBkoEUJdb3Ms+EjLCOyaG/3nKPokw/htbi75FdHGaKED7FgR4D80ozoherm zNtvNvDsyXZ/gyeebM0IgloswHa0lzIJUcj2W3NqjYESGMm7MblRyU/NpLW66v6g7K bOy/wpv5s+zmA== Received: from [192.168.68.112] (ppp118-210-29-70.adl-adc-lon-bras31.tpg.internode.on.net [118.210.29.70]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 2C48664C85; Wed, 31 Jul 2024 14:01:26 +0800 (AWST) Message-ID: <25b2bc6b5b4aec33396f4d6960654e65bf1c3d6e.camel@codeconstruct.com.au> Subject: Re: [PATCH] i2c: don't use ',' after delimiters From: Andrew Jeffery To: Wolfram Sang , linux-i2c@vger.kernel.org Cc: Jean Delvare , Andi Shyti , Elie Morisse , Shyam Sundar S K , Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Baruch Siach , Dong Aisheng , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren , Janusz Krzysztofik , Vignesh R , Vladimir Zapolskiy , Krzysztof Kozlowski , Alim Akhtar , openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, imx@lists.linux.dev, linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org Date: Wed, 31 Jul 2024 15:31:25 +0930 In-Reply-To: <20240730220401.3649-2-wsa+renesas@sang-engineering.com> References: <20240730220401.3649-2-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2024-07-31 at 00:01 +0200, Wolfram Sang wrote: > Delimiters are meant to be last, no need for a ',' there. Remove a > superfluous newline in the ali1535 driver while here. >=20 > Signed-off-by: Wolfram Sang > --- >=20 > @Andi: These changes are super trivial so I put them into one patch. Let > me know if you prefer broken out patches. I think it is better if it > goes through your tree, but I can also take if you prefer. >=20 > drivers/i2c/busses/i2c-ali1535.c | 3 +-- > drivers/i2c/busses/i2c-amd-mp2-plat.c | 2 +- > drivers/i2c/busses/i2c-aspeed.c | 2 +- Thanks for the cleanup. For the Aspeed portion: Acked-by: Andrew Jeffery