From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>
Cc: Kohei Ito <ito.kohei@socionext.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] i2c: designware: Add disabling clocks when probe fails
Date: Wed, 30 Jul 2025 16:32:21 +0300 [thread overview]
Message-ID: <262e1907-5b11-40ca-8fdb-852c38244cdc@linux.intel.com> (raw)
In-Reply-To: <20250724042211.2160339-3-hayashi.kunihiko@socionext.com>
Hi
On 7/24/25 7:22 AM, Kunihiko Hayashi wrote:
> After an error occurs during probing state, dw_i2c_plat_pm_cleanup() is
> called. However, this function doesn't disable clocks and the clock-enable
> count keeps increasing. Should disable these clocks explicitly.
>
> Co-developed-by: Kohei Ito <ito.kohei@socionext.com>
> Signed-off-by: Kohei Ito <ito.kohei@socionext.com>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index edaebfb165f9..f6424dcfdff6 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -308,6 +308,7 @@ static int dw_i2c_plat_probe(struct platform_device *pdev)
>
> exit_probe:
> dw_i2c_plat_pm_cleanup(dev);
> + i2c_dw_prepare_clk(dev, false);
> exit_reset:
> reset_control_assert(dev->rst);
> return ret;
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2025-07-30 13:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 4:22 [PATCH v2 0/2] i2c: designware: Fixes clock issues with platform driver Kunihiko Hayashi
2025-07-24 4:22 ` [PATCH v2 1/2] i2c: designware: Fix clock issue when PM is disabled Kunihiko Hayashi
2025-07-30 13:31 ` Jarkko Nikula
2025-08-19 22:06 ` Andi Shyti
2025-08-20 10:07 ` Kunihiko Hayashi
2025-09-26 7:37 ` Wolfram Sang
2025-07-24 4:22 ` [PATCH v2 2/2] i2c: designware: Add disabling clocks when probe fails Kunihiko Hayashi
2025-07-30 13:32 ` Jarkko Nikula [this message]
2025-09-26 7:39 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=262e1907-5b11-40ca-8fdb-852c38244cdc@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=ito.kohei@socionext.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox