From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Xiangliang Yu <Xiangliang.Yu@amd.com>,
lenb@kernel.org, andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, wsa@the-dreams.de,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, SPG_Linux_Kernel@amd.com
Subject: Re: [PATCH] i2c: designware: Add device HID for future AMD I2C controller
Date: Thu, 10 Mar 2016 23:48:38 +0100 [thread overview]
Message-ID: <2731127.s35Tc35DYy@vostro.rjw.lan> (raw)
In-Reply-To: <56E13104.8050307@linux.intel.com>
On Thursday, March 10, 2016 10:32:04 AM Jarkko Nikula wrote:
> On 03/10/2016 01:34 PM, Xiangliang Yu wrote:
> > Add device HID AMDI0010 to match the AMD ACPI Vendor ID (AMDI) that
> > was registered in http://www.uefi.org/acpi_id_list, and the I2C
> > controller on future AMD paltform will use the HID instead of AMD0010.
> >
> > Signed-off-by: Xiangliang Yu <Xiangliang.Yu@amd.com>
> > ---
> > drivers/acpi/acpi_apd.c | 1 +
> > drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> > index d507cf6..d0aad06 100644
> > --- a/drivers/acpi/acpi_apd.c
> > +++ b/drivers/acpi/acpi_apd.c
> > @@ -143,6 +143,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
> > /* Generic apd devices */
> > #ifdef CONFIG_X86_AMD_PLATFORM_DEVICE
> > { "AMD0010", APD_ADDR(cz_i2c_desc) },
> > + { "AMDI0010", APD_ADDR(cz_i2c_desc) },
> > { "AMD0020", APD_ADDR(cz_uart_desc) },
> > { "AMD0030", },
> > #endif
> > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> > index 438f1b4..d656657 100644
> > --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> > @@ -123,6 +123,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
> > { "80860F41", 0 },
> > { "808622C1", 0 },
> > { "AMD0010", ACCESS_INTR_MASK },
> > + { "AMDI0010", ACCESS_INTR_MASK },
> > { "AMDI0510", 0 },
> > { "APMC0D0F", 0 },
> > { }
> > --
> I guess these changes don't necessarily need to go together? Although I
> think chances to get a conflict is pretty low.
>
> For i2c-designware:
> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
OK, queued up for 4.6, thanks!
Rafael
next prev parent reply other threads:[~2016-03-10 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 11:34 [PATCH] i2c: designware: Add device HID for future AMD I2C controller Xiangliang Yu
2016-03-10 8:32 ` Jarkko Nikula
2016-03-10 22:48 ` Rafael J. Wysocki [this message]
2016-03-12 16:03 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2731127.s35Tc35DYy@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=SPG_Linux_Kernel@amd.com \
--cc=Xiangliang.Yu@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox