linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Lechner <david@lechnology.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: linux-i2c <linux-i2c@vger.kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] eeprom: at24: Change nvmem stride to 1
Date: Mon, 4 Dec 2017 15:22:07 -0600	[thread overview]
Message-ID: <2917d26e-ad37-e118-585c-a479792fbac1@lechnology.com> (raw)
In-Reply-To: <CAMRc=McoGNhQZwdNNwXwKYhjZvLPwUQbbVM4YjgnSnth7fOZTw@mail.gmail.com>

On 12/04/2017 11:44 AM, Bartosz Golaszewski wrote:
> I can't find any documentation on what the stride config option does
> in nvmem, but looking at the code it's only used for alignment checks
> in nvmem core, so this patch should be ok. Still: I'm wondering if it
> shouldn't depend on the size of the eeprom or if we shouldn't make the
> chip you're using a special case.

I am just guessing on the usage too, but I assume it is for memory 
alignment for other types of nvmem devices that only read words (2, 4 or 
8 bytes) at a time. I don't see anything in the at24 code that says we 
can't read any arbitrary starting I2C register, so I don't think we 
should have any problems.

> 
> @David: what is the chip you're using?

Microchip 24FC128

> Is it an at24mac402 by any
> chance? Were you affected by the read problem we fixed recently[1][2]
> in at24?

No and no.

> 
> @Srinivas: any comments on that?
> 
> Thanks,
> Bartosz
> 
> [1] http://patchwork.ozlabs.org/patch/841852/
> [2] http://patchwork.ozlabs.org/patch/841876/
> 

  reply	other threads:[~2017-12-04 21:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-04  1:54 [PATCH] eeprom: at24: Change nvmem stride to 1 David Lechner
2017-12-04 17:44 ` Bartosz Golaszewski
2017-12-04 21:22   ` David Lechner [this message]
2017-12-06  9:44   ` Srinivas Kandagatla
2017-12-06 10:25 ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2917d26e-ad37-e118-585c-a479792fbac1@lechnology.com \
    --to=david@lechnology.com \
    --cc=brgl@bgdev.pl \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).