From: Lars-Peter Clausen <lars@metafoo.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Wolfram Sang <wsa@kernel.org>
Cc: Michal Simek <michal.simek@amd.com>,
Shubhrajyoti Datta <Shubhrajyoti.datta@amd.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: i2c: cadence: Document reset property
Date: Fri, 31 Mar 2023 10:11:43 -0700 [thread overview]
Message-ID: <292e5efd-1a10-d1e6-0185-1ce113eee233@metafoo.de> (raw)
In-Reply-To: <6b997dfa-1377-8d2e-ce4f-3f8f7407e6b4@linaro.org>
On 3/31/23 02:42, Krzysztof Kozlowski wrote:
> On 30/03/2023 20:04, Lars-Peter Clausen wrote:
>> The Cadence I2C controller has an external reset that needs to be
>> de-asserted before the I2C controller can be accessed.
>>
>> Document the `resets` devicetree property that can be used to describe how
>> the reset signal is connected.
> You could add it also to the example to have complete picture (and
> validate your change).
>
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
When I resend with it added to the example, do you want me to keep or
drop the acked-by?
next prev parent reply other threads:[~2023-03-31 17:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 18:04 [PATCH 1/2] dt-bindings: i2c: cadence: Document reset property Lars-Peter Clausen
2023-03-30 18:04 ` [PATCH 2/2] i2c: cadence: Add reset controller support Lars-Peter Clausen
2023-03-31 6:49 ` Michal Simek
2023-03-31 16:42 ` Lars-Peter Clausen
2023-03-31 9:42 ` [PATCH 1/2] dt-bindings: i2c: cadence: Document reset property Krzysztof Kozlowski
2023-03-31 17:11 ` Lars-Peter Clausen [this message]
2023-03-31 20:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=292e5efd-1a10-d1e6-0185-1ce113eee233@metafoo.de \
--to=lars@metafoo.de \
--cc=Shubhrajyoti.datta@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=robh+dt@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox