From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] i2c: slave-eeprom: fix boundary check when using sysfs Date: Tue, 20 Jan 2015 15:52:15 +0200 Message-ID: <2988844.NmFWX0K5r9@avalon> References: <1421684575-6679-1-git-send-email-wsa@the-dreams.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1421684575-6679-1-git-send-email-wsa@the-dreams.de> Sender: linux-sh-owner@vger.kernel.org To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm , Simon Horman , Geert Uytterhoeven , Debora Grosse List-Id: linux-i2c@vger.kernel.org Hi Wolfram, Thank you for the patch. On Monday 19 January 2015 17:22:55 Wolfram Sang wrote: > From: Wolfram Sang > > Due to a copy&paste error, the last byte of the shared memory was not > accessible via sysfs. > > Reported-by: Debora Grosse > Signed-off-by: Wolfram Sang Acked-by: Laurent Pinchart > --- > drivers/i2c/i2c-slave-eeprom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/i2c-slave-eeprom.c b/drivers/i2c/i2c-slave-eeprom.c > index f432f81b0414..8f417e9054ac 100644 > --- a/drivers/i2c/i2c-slave-eeprom.c > +++ b/drivers/i2c/i2c-slave-eeprom.c > @@ -74,7 +74,7 @@ static ssize_t i2c_slave_eeprom_bin_read(struct file > *filp, struct kobject *kobj struct eeprom_data *eeprom; > unsigned long flags; > > - if (off + count >= attr->size) > + if (off + count > attr->size) > return -EFBIG; > > eeprom = dev_get_drvdata(container_of(kobj, struct device, kobj)); > @@ -92,7 +92,7 @@ static ssize_t i2c_slave_eeprom_bin_write(struct file > *filp, struct kobject *kob struct eeprom_data *eeprom; > unsigned long flags; > > - if (off + count >= attr->size) > + if (off + count > attr->size) > return -EFBIG; > > eeprom = dev_get_drvdata(container_of(kobj, struct device, kobj)); -- Regards, Laurent Pinchart