From: Mukesh Savaliya <mukesh.savaliya@oss.qualcomm.com>
To: Bartosz Golaszewski <brgl@kernel.org>, Vinod Koul <vkoul@kernel.org>
Cc: viken.dadhaniya@oss.qualcomm.com, andi.shyti@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
Frank.Li@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, dmitry.baryshkov@oss.qualcomm.com,
linmq006@gmail.com, quic_jseerapu@quicinc.com,
zhengxingda@iscas.ac.cn, kees@kernel.org, agross@kernel.org,
linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dmaengine@vger.kernel.org, krzysztof.kozlowski@oss.qualcomm.com,
bartosz.golaszewski@oss.qualcomm.com,
bjorn.andersson@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com
Subject: Re: [PATCH v8 2/4] dmaengine: qcom: gpi: Add lock/unlock TREs for multi-owner I2C transfers
Date: Thu, 16 Jul 2026 18:05:58 +0530 [thread overview]
Message-ID: <2ac2cdcb-f671-4f7a-83c3-bb05fcf4259f@oss.qualcomm.com> (raw)
In-Reply-To: <CAMRc=Mc_4TZ6QjUgQmLehBb_6f90bamYFhE5S_6m-Poem0-u1Q@mail.gmail.com>
On 7/16/2026 5:39 PM, Bartosz Golaszewski wrote:
> On Wed, 15 Jul 2026 17:33:40 +0200, Vinod Koul <vkoul@kernel.org> said:
>> On 08-07-26, 10:40, Mukesh Kumar Savaliya wrote:
>>
>>> +/**
>>> + * enum gpi_lock_action - request lock/unlock TRE sequencing
>>> + * @GPI_LOCK_NONE: No lock/unlock TRE requested for this transfer
>>> + * @GPI_LOCK_ACQUIRE: Emit a lock TRE before the transfer
>>> + * @GPI_LOCK_RELEASE: Emit an unlock TRE after the transfer
>>> + *
>>> + * Used by protocol drivers for multi-owner controller setups (e.g. when
>>> + * DeviceTree indicates the controller is shared via qcom,qup-multi-owner).
>>> + */
>>> +enum gpi_lock_action {
>>> + GPI_LOCK_NONE = 0,
>>> + GPI_LOCK_ACQUIRE,
>>> + GPI_LOCK_RELEASE,
>>
>> Can qualcomm people please align on LOCK/UNLOCK interface? This is
>> second interface I am seeing now. Can you folks align internally on how
>> clients should communicating lock/unlock across different qualcomm
>> dmaengine drivers
>>
>
Sure Vinod,Thanks for your review and updating on direction.
I thought reverse to not pass transfer index to GSI driver.
> As discussed internally - this driver should follow the pattern we established
> for BAM DMA where we don't require consumers to be aware of the locking
> happening to any larger degree than is absolutely required (for instance:
> passing the address of the appropriate scratchpad register as is the case for
> BAM DMA).
>
Yes, Bartosz, i understand. let me align on this and follow BAM DMA
design, will review with you OR get BAM DMA changes.
If Consumers do not posses knowledge of locking/unlocking, DMA engine
(here GSI) need to have some decision making knowledge. e.g. First
transfer and last transfer.
let me share with you and then will upload.
> Bart
next prev parent reply other threads:[~2026-07-16 12:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 5:10 [PATCH v8 0/4] Enable multi-owner I2C support for QCOM GENI controllers Mukesh Kumar Savaliya
2026-07-08 5:10 ` [PATCH v8 1/4] dt-bindings: i2c: qcom,i2c-geni: Document multi-owner controller support Mukesh Kumar Savaliya
2026-07-16 3:14 ` Bjorn Andersson
2026-07-16 12:41 ` Mukesh Savaliya
2026-07-08 5:10 ` [PATCH v8 2/4] dmaengine: qcom: gpi: Add lock/unlock TREs for multi-owner I2C transfers Mukesh Kumar Savaliya
2026-07-15 12:22 ` Konrad Dybcio
2026-07-15 15:33 ` Vinod Koul
2026-07-16 12:09 ` Bartosz Golaszewski
2026-07-16 12:35 ` Mukesh Savaliya [this message]
2026-07-08 5:10 ` [PATCH v8 3/4] soc: qcom: geni-se: Keep pinctrl active for multi-owner controllers Mukesh Kumar Savaliya
2026-07-08 5:10 ` [PATCH v8 4/4] i2c: qcom-geni: Support multi-owner controllers in GPI mode Mukesh Kumar Savaliya
2026-07-15 12:24 ` Konrad Dybcio
2026-07-16 12:47 ` Mukesh Savaliya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ac2cdcb-f671-4f7a-83c3-bb05fcf4259f@oss.qualcomm.com \
--to=mukesh.savaliya@oss.qualcomm.com \
--cc=Frank.Li@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=kees@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linmq006@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_jseerapu@quicinc.com \
--cc=robh@kernel.org \
--cc=viken.dadhaniya@oss.qualcomm.com \
--cc=vkoul@kernel.org \
--cc=zhengxingda@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox