public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Thomas Weißschuh" <linux@weissschuh.net>,
	"Andi Shyti" <andi.shyti@kernel.org>,
	"Jean Delvare" <jdelvare@suse.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH v2 4/4] i2c: piix4: Register SPDs
Date: Fri, 28 Jun 2024 16:09:09 -0700	[thread overview]
Message-ID: <2bbdb1bd-ea4d-4c14-9ea7-9fce09ac76b7@roeck-us.net> (raw)
In-Reply-To: <20240627-piix4-spd-v2-4-617ce47b8ff4@weissschuh.net>

On 6/27/24 10:48, Thomas Weißschuh wrote:
> The piix4 I2C bus can carry SPDs, register them if present.
> Only look on bus 0, as this is where the SPDs seem to be located.
> 
> Only the first 8 slots are supported. If the system has more,
> then these will not be visible.
> 
> The AUX bus can not be probed as on some platforms it reports all
> devices present and all reads return "0".
> This would allow the ee1004 to be probed incorrectly.

Was this reported somewhere ? I don't see it happen on any of my systems
(of course that doesn't really mean anything).

> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

Reviewed-and-tested-by: Guenter Roeck <linux@roeck-us.net>

Thanks,
Guenter


  reply	other threads:[~2024-06-28 23:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27 17:48 [PATCH v2 0/4] i2c: smbus cleanups and SPD support for piix4 Thomas Weißschuh
2024-06-27 17:48 ` [PATCH v2 1/4] i2c: smbus: only limit max banks to eight Thomas Weißschuh
2024-07-04 21:57   ` Andi Shyti
2024-07-05  5:55     ` Thomas Weißschuh 
2024-07-05  7:26       ` Heiner Kallweit
2024-07-05 11:56       ` Andi Shyti
2024-07-09 17:27         ` Thomas Weißschuh
2024-06-27 17:48 ` [PATCH v2 2/4] i2c: smbus: probe SPDs on a best-effort basis Thomas Weißschuh
2024-06-27 17:48 ` [PATCH v2 3/4] i2c: smbus: drop warning about muxed segments requirement Thomas Weißschuh
2024-06-27 17:48 ` [PATCH v2 4/4] i2c: piix4: Register SPDs Thomas Weißschuh
2024-06-28 23:09   ` Guenter Roeck [this message]
2024-06-29  7:19     ` Thomas Weißschuh
2024-06-29 14:01       ` Guenter Roeck
2024-06-29 14:09       ` Guenter Roeck
2024-07-04 21:45       ` Andi Shyti
2024-07-04 21:56 ` [PATCH v2 0/4] i2c: smbus cleanups and SPD support for piix4 Andi Shyti
2024-07-05  5:51   ` Thomas Weißschuh 

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bbdb1bd-ea4d-4c14-9ea7-9fce09ac76b7@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=andi.shyti@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox