From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Jean Delvare <jdelvare@suse.de>
Cc: linux-kernel@lists.codethink.co.uk, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c-amd756: share definition of amd756_smbus
Date: Mon, 20 Apr 2020 17:26:56 +0100 [thread overview]
Message-ID: <2c6246c3-5d89-05f1-36c2-6515789d5dcd@codethink.co.uk> (raw)
In-Reply-To: <20200415125859.5d6297b2@endymion>
On 15/04/2020 11:58, Jean Delvare wrote:
> Hi Ben,
>
> On Fri, 20 Dec 2019 10:59:54 +0000, Ben Dooks (Codethink) wrote:
>> Add a shared header to declare amd756_smbus that is used
>> by two files, to remove the following sparse warning:
>>
>> drivers/i2c/busses/i2c-amd756.c:286:20: warning: symbol 'amd756_smbus' was not declared. Should it be static?
>
> I can't see this warning, not even with W=1. What did you do to see it?
Was running C=1, looks like output from sparse.
prev parent reply other threads:[~2020-04-20 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191220105954.382490-1-ben.dooks@codethink.co.uk>
2020-04-15 10:58 ` [PATCH] i2c-amd756: share definition of amd756_smbus Jean Delvare
2020-04-20 16:26 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c6246c3-5d89-05f1-36c2-6515789d5dcd@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@lists.codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox