* [PATCH v1 1/2] i2c: designware: constify abort_sources
@ 2024-01-22 3:31 Raag Jadav
2024-01-22 3:31 ` [PATCH v1 2/2] i2c: designware: constify regmap_config Raag Jadav
2024-10-02 9:18 ` [PATCH v1 1/2] i2c: designware: constify abort_sources Andi Shyti
0 siblings, 2 replies; 7+ messages in thread
From: Raag Jadav @ 2024-01-22 3:31 UTC (permalink / raw)
To: jarkko.nikula, mika.westerberg, andriy.shevchenko, jsd,
andi.shyti
Cc: linux-i2c, linux-kernel, Raag Jadav
We never modify abort_sources, mark it as const.
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
drivers/i2c/busses/i2c-designware-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c
index affcfb243f0f..39c956b0a72d 100644
--- a/drivers/i2c/busses/i2c-designware-common.c
+++ b/drivers/i2c/busses/i2c-designware-common.c
@@ -28,7 +28,7 @@
#include "i2c-designware-core.h"
-static char *abort_sources[] = {
+static const char *const abort_sources[] = {
[ABRT_7B_ADDR_NOACK] =
"slave address not acknowledged (7bit mode)",
[ABRT_10ADDR1_NOACK] =
--
2.35.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v1 2/2] i2c: designware: constify regmap_config
2024-01-22 3:31 [PATCH v1 1/2] i2c: designware: constify abort_sources Raag Jadav
@ 2024-01-22 3:31 ` Raag Jadav
2024-01-22 9:44 ` Jarkko Nikula
2024-10-02 9:18 ` [PATCH v1 1/2] i2c: designware: constify abort_sources Andi Shyti
1 sibling, 1 reply; 7+ messages in thread
From: Raag Jadav @ 2024-01-22 3:31 UTC (permalink / raw)
To: jarkko.nikula, mika.westerberg, andriy.shevchenko, jsd,
andi.shyti
Cc: linux-i2c, linux-kernel, Raag Jadav
We never modify regmap_config, mark it as const.
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
drivers/i2c/busses/i2c-designware-platdrv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index 855b698e99c0..d122ef349b1c 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -100,7 +100,7 @@ static int bt1_i2c_write(void *context, unsigned int reg, unsigned int val)
BT1_I2C_CTL_GO | BT1_I2C_CTL_WR | (reg & BT1_I2C_CTL_ADDR_MASK));
}
-static struct regmap_config bt1_i2c_cfg = {
+static const struct regmap_config bt1_i2c_cfg = {
.reg_bits = 32,
.val_bits = 32,
.reg_stride = 4,
--
2.35.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v1 2/2] i2c: designware: constify regmap_config
2024-01-22 3:31 ` [PATCH v1 2/2] i2c: designware: constify regmap_config Raag Jadav
@ 2024-01-22 9:44 ` Jarkko Nikula
2024-02-08 10:46 ` Raag Jadav
0 siblings, 1 reply; 7+ messages in thread
From: Jarkko Nikula @ 2024-01-22 9:44 UTC (permalink / raw)
To: Raag Jadav, mika.westerberg, andriy.shevchenko, jsd, andi.shyti
Cc: linux-i2c, linux-kernel
On 1/22/24 05:31, Raag Jadav wrote:
> We never modify regmap_config, mark it as const.
>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
> drivers/i2c/busses/i2c-designware-platdrv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Both:
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 2/2] i2c: designware: constify regmap_config
2024-01-22 9:44 ` Jarkko Nikula
@ 2024-02-08 10:46 ` Raag Jadav
2024-03-04 7:58 ` Raag Jadav
0 siblings, 1 reply; 7+ messages in thread
From: Raag Jadav @ 2024-02-08 10:46 UTC (permalink / raw)
To: Jarkko Nikula
Cc: mika.westerberg, andriy.shevchenko, jsd, andi.shyti, linux-i2c,
linux-kernel
On Mon, Jan 22, 2024 at 11:44:22AM +0200, Jarkko Nikula wrote:
> On 1/22/24 05:31, Raag Jadav wrote:
> > We never modify regmap_config, mark it as const.
> >
> > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > ---
> > drivers/i2c/busses/i2c-designware-platdrv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> Both:
>
> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Bump.
Anything I can do to move these forward?
Raag
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 2/2] i2c: designware: constify regmap_config
2024-02-08 10:46 ` Raag Jadav
@ 2024-03-04 7:58 ` Raag Jadav
0 siblings, 0 replies; 7+ messages in thread
From: Raag Jadav @ 2024-03-04 7:58 UTC (permalink / raw)
To: Jarkko Nikula, andi.shyti
Cc: mika.westerberg, andriy.shevchenko, jsd, andi.shyti, linux-i2c,
linux-kernel
On Thu, Feb 08, 2024 at 12:46:07PM +0200, Raag Jadav wrote:
> On Mon, Jan 22, 2024 at 11:44:22AM +0200, Jarkko Nikula wrote:
> > On 1/22/24 05:31, Raag Jadav wrote:
> > > We never modify regmap_config, mark it as const.
> > >
> > > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > > ---
> > > drivers/i2c/busses/i2c-designware-platdrv.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > Both:
> >
> > Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
>
> Bump.
>
> Anything I can do to move these forward?
Hi Andi,
Are these worth moving forward?
Raag
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 1/2] i2c: designware: constify abort_sources
2024-01-22 3:31 [PATCH v1 1/2] i2c: designware: constify abort_sources Raag Jadav
2024-01-22 3:31 ` [PATCH v1 2/2] i2c: designware: constify regmap_config Raag Jadav
@ 2024-10-02 9:18 ` Andi Shyti
2024-10-03 2:58 ` Raag Jadav
1 sibling, 1 reply; 7+ messages in thread
From: Andi Shyti @ 2024-10-02 9:18 UTC (permalink / raw)
To: Raag Jadav
Cc: jarkko.nikula, mika.westerberg, andriy.shevchenko, jsd, linux-i2c,
linux-kernel
Hi Raag,
On Mon, Jan 22, 2024 at 09:01:07AM GMT, Raag Jadav wrote:
> We never modify abort_sources, mark it as const.
>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
we meet in a different context :-)
Sorry I have missed this patch. I applied it to i2c/i2c-host. The
second patch was already sent here 21ac0359f72a90.
Thanks,
Andi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 1/2] i2c: designware: constify abort_sources
2024-10-02 9:18 ` [PATCH v1 1/2] i2c: designware: constify abort_sources Andi Shyti
@ 2024-10-03 2:58 ` Raag Jadav
0 siblings, 0 replies; 7+ messages in thread
From: Raag Jadav @ 2024-10-03 2:58 UTC (permalink / raw)
To: Andi Shyti
Cc: jarkko.nikula, mika.westerberg, andriy.shevchenko, jsd, linux-i2c,
linux-kernel
On Wed, Oct 02, 2024 at 11:18:34AM +0200, Andi Shyti wrote:
> Hi Raag,
>
> On Mon, Jan 22, 2024 at 09:01:07AM GMT, Raag Jadav wrote:
> > We never modify abort_sources, mark it as const.
> >
> > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
>
> we meet in a different context :-)
Small world :)
> Sorry I have missed this patch. I applied it to i2c/i2c-host. The
> second patch was already sent here 21ac0359f72a90.
Awesome.
Raag
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-10-03 2:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-22 3:31 [PATCH v1 1/2] i2c: designware: constify abort_sources Raag Jadav
2024-01-22 3:31 ` [PATCH v1 2/2] i2c: designware: constify regmap_config Raag Jadav
2024-01-22 9:44 ` Jarkko Nikula
2024-02-08 10:46 ` Raag Jadav
2024-03-04 7:58 ` Raag Jadav
2024-10-02 9:18 ` [PATCH v1 1/2] i2c: designware: constify abort_sources Andi Shyti
2024-10-03 2:58 ` Raag Jadav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).