From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 896D9C4332F for ; Thu, 17 Nov 2022 14:44:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239608AbiKQOoG (ORCPT ); Thu, 17 Nov 2022 09:44:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239913AbiKQOnc (ORCPT ); Thu, 17 Nov 2022 09:43:32 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29B0030E for ; Thu, 17 Nov 2022 06:43:29 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id s24so2940592ljs.11 for ; Thu, 17 Nov 2022 06:43:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HQLQpf3kqVigsxlHZz3VInqB29DX3Of3V5vUpblQjaE=; b=cgEyuXJ9bSA2nbbeLhNB/uy9KIR0uK9QNQwKu5wOFqsIeCJ9+AwrtgI/d2KpiRUTs8 GWR0arDbaBDl0MVo+Dtx+mM+bkRFgxla9SBM0YbFI/3nSOFb+8Is86Tw5fnv5gkSJ2Q0 JLE142Ah2VMsEeKe+AwVz0lN65TV9i+LF9txiuORSY/fseVNcQq2GSMjPyvlATNAHPKF IC9nlrDeLffvuvallMwZZp1vqnYLr57l9yiD3i6+srDDJID4MPV0jwUDy1H5wA7tVctv ker2R3Gq398hxtYIKX8wRSWHsQgY2FrPFCBqmbLxkyggfbkIRr+TuN0bnB/iIfOAynYj SGxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HQLQpf3kqVigsxlHZz3VInqB29DX3Of3V5vUpblQjaE=; b=dGh5gNkt2OhNs/M76pMnFpbzwAqFXH57XHUr0Vaa4paNzDQ08j+UWGTr4nGqXznnSj B8KOsb7SSpY+XXZoH8mottPnThky/197nd0F/EYN5EvcHYYWaJ5BzVddtLoWXC5yuxBO /HR2BbDjQtZEX3+DzwBJ6qmh1Gga9swSiN0g2aek9LrAfWBEvWgc0dQ7ntZlCs3RWdM2 R9zoIceWIOQEHU22Ei7ozKriCJvqKSDUYRKmQvKQntmPxy+Lh7pS4asRH3TlDiHrGtZC 032Zgn6Ydehn8kKbGv+rUDthZeUcpU2dPa1nz9qIsMgnqIUQHInmOopMfbZ/oHSNLrma 4gNg== X-Gm-Message-State: ANoB5pm467R9ibVHgCkghb8fMhQV0JVOKiNWQGbGwu6kR2eooqtiE20b ZygWz4Obck25P/CrpE8GzoBrVQ== X-Google-Smtp-Source: AA0mqf6KhLVQFBsdyDJL/myJ+eCpADXPNWOU/Inb33v6Vdhy3hm3CLZ95yi7AADthY2wEk9Y5+1DFA== X-Received: by 2002:a2e:9456:0:b0:278:eef5:8d19 with SMTP id o22-20020a2e9456000000b00278eef58d19mr1023924ljh.429.1668696207539; Thu, 17 Nov 2022 06:43:27 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id k20-20020ac24f14000000b0049ad315cfc3sm176956lfr.162.2022.11.17.06.43.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Nov 2022 06:43:27 -0800 (PST) Message-ID: <2cfdec0d-4c03-012a-df29-6d92cd87bab5@linaro.org> Date: Thu, 17 Nov 2022 15:43:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/6] dt-bindings: qcom: geni-se: document I2C Master Hub wrapper variant Content-Language: en-US To: Neil Armstrong , Rob Herring , Konrad Dybcio , Andy Gross , Krzysztof Kozlowski , Bjorn Andersson Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20221114-narmstrong-sm8550-upstream-i2c-master-hub-v1-0-64449106a148@linaro.org> <20221114-narmstrong-sm8550-upstream-i2c-master-hub-v1-1-64449106a148@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20221114-narmstrong-sm8550-upstream-i2c-master-hub-v1-1-64449106a148@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 16/11/2022 11:21, Neil Armstrong wrote: > The I2C Master Hub is a stripped down version of the GENI Serial Engine > QUP Wrapper Controller but only supporting I2C serial engines without > DMA support. > > This documents the variant compatible and forbids UART and SPI sub-nodes, Do not use "This commit/patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > and removes requirement for the Master AHB clock and iommu property. > > Signed-off-by: Neil Armstrong > --- > .../devicetree/bindings/soc/qcom/qcom,geni-se.yaml | 43 ++++++++++++++++++---- > 1 file changed, 35 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml > index 2bf5293fc995..6657e74df629 100644 > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml > @@ -21,20 +21,15 @@ properties: > compatible: > enum: > - qcom,geni-se-qup > + - qcom,geni-se-i2c-master-hub > > reg: > description: QUP wrapper common register address and length. > maxItems: 1 > > - clock-names: > - items: > - - const: m-ahb > - - const: s-ahb > + clock-names: true minItems: 1, maxItems: 2, instead. > > - clocks: > - items: > - - description: Master AHB Clock > - - description: Slave AHB Clock > + clocks: true minItems: 1, maxItems: 2, instead. > > "#address-cells": > const: 2 > @@ -81,6 +76,38 @@ patternProperties: > description: GENI Serial Engine based UART Controller. > $ref: /schemas/serial/qcom,serial-geni-qcom.yaml# > > +if: Put it under allOf, to avoid re-indenting when number of if's grow. > + properties: > + compatible: > + contains: > + const: qcom,geni-se-i2c-master-hub > Best regards, Krzysztof