From mboxrd@z Thu Jan 1 00:00:00 1970 From: Enric Balletbo i Serra Subject: Re: [PATCH 1/2] platform/chrome: chromeos_laptop: make I2C API conversion complete Date: Mon, 30 Mar 2020 16:11:06 +0200 Message-ID: <2d4269eb-0f17-47c8-d393-a3887a72526e@collabora.com> References: <20200326210952.12857-1-wsa+renesas@sang-engineering.com> <20200326210952.12857-2-wsa+renesas@sang-engineering.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from bhuna.collabora.co.uk ([46.235.227.227]:60904 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725268AbgC3OLL (ORCPT ); Mon, 30 Mar 2020 10:11:11 -0400 In-Reply-To: <20200326210952.12857-2-wsa+renesas@sang-engineering.com> Content-Language: en-US Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Wolfram Sang , linux-i2c@vger.kernel.org Cc: Benson Leung , linux-kernel@vger.kernel.org Hi Wolfram, On 26/3/20 22:09, Wolfram Sang wrote: > When converting to i2c_new_scanned_device(), it was overlooked that a > conversion to i2c_new_client_device() was also needed. Fix it. > > Fixes: c82ebf1bf738 ("platform/chrome: chromeos_laptop: Convert to i2c_new_scanned_device") > Signed-off-by: Wolfram Sang > --- > drivers/platform/chrome/chromeos_laptop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/chrome/chromeos_laptop.c b/drivers/platform/chrome/chromeos_laptop.c > index 4f3651fcd9fe..472a03daa869 100644 > --- a/drivers/platform/chrome/chromeos_laptop.c > +++ b/drivers/platform/chrome/chromeos_laptop.c > @@ -103,7 +103,7 @@ chromes_laptop_instantiate_i2c_device(struct i2c_adapter *adapter, > pr_debug("%d-%02x is probed at %02x\n", > adapter->nr, info->addr, dummy->addr); > i2c_unregister_device(dummy); > - client = i2c_new_device(adapter, info); > + client = i2c_new_client_device(adapter, info); > } > } > > Queued for 5.7. Thanks. Enric